Summary: | Wrongly handled underline/reverse effects | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | leo zhu <lucida> |
Component: | general | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
leo zhu
2004-01-29 12:58:20 UTC
Second line? You mean "make directory long enough that it doesn't fit into one terminal line"? Works here with and without line break in the directory name. the bug still exists in kde 3.2.1 here is a screenshot http://61.153.200.30/lucida/konsole-bug.png This might not happen with the first "ls -l", but would appear in a 2nd or 3rd try. The bug still exists in kde 3.2.2(konsole 1.3.2) . A quick way to reproduce the bug is to run the below command in an 80x25 konsole terminal: $ echo -e '\033[33;04maaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\033[00m' The underline extends to the end of second line in this case, which isn't correct. The same problem exists for reverse property(\033[7m). CVS commit by waba: Default rendition should be used when clearing screen areas (BR73750) CCMAIL: 73750-done@bugs.kde.org M +6 -3 TEScreen.cpp 1.79.2.3 --- kdebase/konsole/konsole/TEScreen.cpp #1.79.2.2:1.79.2.3 @@ -918,10 +918,13 @@ void TEScreen::clearImage(int loca, int clearSelection(); } + for (i = loca; i <= loce; i++) { + // Use the current colors but the default rendition + // Check with: echo -e '\033[41;33;07m\033[2Khello world\033[00m' image[i].c = c; - image[i].f = ef_fg; //DEFAULT_FORE_COLOR; //FIXME: xterm and linux/ansi - image[i].b = ef_bg; //DEFAULT_BACK_COLOR; // many have different - image[i].r = ef_re; //DEFAULT_RENDITION; // ideas here. + image[i].f = cu_fg; + image[i].b = cu_bg; + image[i].r = DEFAULT_RENDITION; } |