Summary: | [PATCH] kopete trying to save password to kwallet when the "Save password" checkbox isn't clicked | ||
---|---|---|---|
Product: | [Applications] kopete | Reporter: | Daniel <leva> |
Component: | libkopete | Assignee: | Kopete Developers <kopete-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | carsten.schlipf |
Priority: | NOR | ||
Version: | 0.8.0 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Treat null passwords as 'remember password == false' |
Description
Daniel
2004-01-04 11:31:03 UTC
Not a showstopper for 0.8, but I have a patch for both CVS HEAD and the 3.2 branch after KDE 3.2 is created. Martijn Created attachment 4211 [details]
Treat null passwords as 'remember password == false'
Please review. Do not commit before KDE 3.2 is tagged tomorrow. It's not a
showstopper IMO, but can safely go into the branch for Kopete 0.8.1.
Martijn
*** Bug 73123 has been marked as a duplicate of this bug. *** CVS commit by mattr: Apply Martijn's patch for bug 71804. Treat null passwords as rememberPassword = false. I assume that lilachaze's new KopetePassword stuff should take care of the rest in HEAD when it gets merged back in. CCMAIL: 71804-done@bugs.kde.org M +14 -1 kopeteaccount.cpp 1.78.2.4 --- kdenetwork/kopete/libkopete/kopeteaccount.cpp #1.78.2.3:1.78.2.4 @@ -357,5 +357,18 @@ QString KopeteAccount::password( bool er void KopeteAccount::setPassword( const QString &pass ) { - d->rememberPassword = !pass.isNull(); + if ( pass.isNull() ) + { + // FIXME: This is a quick workaround for the problem that after Jason + // added the rememberPassword flag he didn't accordingly update + // all plugins to setRememberPassword( false ), so they now + // try to set a null pass when the pass is not to be remembered. + // + // After KDE 3.2 this should be fixed by disallowing null + // passwords here and adding said property setter method - Martijn + d->password = pass; + d->rememberPassword = false; + writeConfig( configGroup() ); + return; + } #if KDE_IS_VERSION( 3, 1, 90 ) |