Bug 71804 - [PATCH] kopete trying to save password to kwallet when the "Save password" checkbox isn't clicked
Summary: [PATCH] kopete trying to save password to kwallet when the "Save password" ch...
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: libkopete (show other bugs)
Version: 0.8.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-04 11:31 UTC by Daniel
Modified: 2004-02-12 00:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Treat null passwords as 'remember password == false' (1.11 KB, patch)
2004-01-17 18:17 UTC, Martijn Klingens
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel 2004-01-04 11:31:03 UTC
Version:           0.7.94 (using KDE Devel)
Installed from:    Compiled sources
OS:          Linux

When adding a new connection (protocol, for example iCQ), and unchecking the "Save password" checkbox, then clicking ok, Kopete wants to save something to the kwallet (or create a new wallet in kwallet if there isn't any).
Comment 1 Martijn Klingens 2004-01-17 18:14:06 UTC
Not a showstopper for 0.8, but I have a patch for both CVS HEAD and the 3.2 branch after KDE 3.2 is created.

Martijn
Comment 2 Martijn Klingens 2004-01-17 18:17:16 UTC
Created attachment 4211 [details]
Treat null passwords as 'remember password == false'

Please review. Do not commit before KDE 3.2 is tagged tomorrow. It's not a
showstopper IMO, but can safely go into the branch for Kopete 0.8.1.

Martijn
Comment 3 Matt Rogers 2004-01-21 19:09:36 UTC
*** Bug 73123 has been marked as a duplicate of this bug. ***
Comment 4 Matt Rogers 2004-02-12 00:53:08 UTC
CVS commit by mattr: 

Apply Martijn's patch for bug 71804. Treat null passwords as rememberPassword
 = false.

I assume that lilachaze's new KopetePassword stuff should take care of the rest in HEAD 
when it gets merged back in.

CCMAIL: 71804-done@bugs.kde.org


  M +14 -1     kopeteaccount.cpp   1.78.2.4


--- kdenetwork/kopete/libkopete/kopeteaccount.cpp  #1.78.2.3:1.78.2.4
@@ -357,5 +357,18 @@ QString KopeteAccount::password( bool er
 void KopeteAccount::setPassword( const QString &pass )
 {
-        d->rememberPassword = !pass.isNull();
+        if ( pass.isNull() )
+        {
+                // FIXME: This is a quick workaround for the problem that after Jason
+                //        added the rememberPassword flag he didn't accordingly update
+                //        all plugins to setRememberPassword( false ), so they now
+                //        try to set a null pass when the pass is not to be remembered.
+                //
+                //        After KDE 3.2 this should be fixed by disallowing null
+                //        passwords here and adding said property setter method - Martijn
+                d->password = pass;
+                d->rememberPassword = false;
+                writeConfig( configGroup() );
+                return;
+        }
 
 #if KDE_IS_VERSION( 3, 1, 90 )


Comment 5 Martijn Klingens 2004-02-12 10:35:58 UTC
On Thursday 12 February 2004 00:53, Matt Rogers wrote:
> Apply Martijn's patch for bug 71804. Treat null passwords as
> rememberPassword = false.

Actually, I asked Richard last weekend and he said this is no longer needed :)