Summary: | notebook lcd screen brightness | ||
---|---|---|---|
Product: | klaptopdaemon | Reporter: | Cristián González <cgonzalez> |
Component: | general | Assignee: | Paul Campbell <paul> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Cristián González
2003-11-27 15:48:29 UTC
This is when Screen Brightness is setting to MAX cat /proc/acpi/toshiba/lcd brightness: 0 brightness_levels: 8 This is when i scroll down brightness a little cat /proc/acpi/toshiba/lcd brightness: 7 brightness_levels: 8 I had the same problem here (Toshiba satellite 2450) and after looking at it i think i have found the problem exactly in the file 'portable.cpp' at line 1460. The slider for brightness adjusment gives a vaule between 0 and 255 for bright, while the toshiba acpi driver only knows about 8 levels of bright (from 0 to 7) to solve this the >> bit operator is used moving the bits 5 positions, however, in the original file, the operation is done with: val=(val+7)>>5 so, if we have a val>249 the thing goes a bit up with the +7 and when masking with val&7 to set the bright we are setting brightness 0 in the acpi. That's why if you set the TOP brightness in the slide in a toshiba computer you get a dark screen so, i think it should read val=val>>5 (without the +7). It works nicely now. :-) (sorry; i don't know how to use diff, yet... hope this helps...) Fixed in CVS HEAD, thanks for the solution. |