Summary: | Cannot build rpms from source tarball, spec file needs changes | ||
---|---|---|---|
Product: | [Applications] kst | Reporter: | Matthew Truch <matt> |
Component: | general | Assignee: | kst |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 1.x | ||
Target Milestone: | --- | ||
Platform: | RedHat Enterprise Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Patch to fix spec file |
Description
Matthew Truch
2003-11-08 18:56:30 UTC
Created attachment 3081 [details]
Patch to fix spec file
The attached patch adds appropriate file entries. It also sets the %defattr so
all files are installed with owner:group of root:root, and does an ldconfig
after install and removal (so libkst.so.1 for example, can be found after a
user installs kst for the first time).
Recommendation: remove the .spec file from the source-code .tar.gz. Distributions make each their own SPECs for their own system, with their own specificities. A KDE program cannot hope to make one .spec to work in every distribution. I don't think that removing the spec file makes any sense. Distributions *do* make their own spec filess, and will ignore any spec that comes with the tarball. But having a spec file that works for other people (whose distribution doesn't yet package kst....I don't think that many distros include kst yet) is a good thing. Also, the changes made above had nothing to do with tweaks for a specific distro, but for making the spec file complete (ie, the spec file must list all files installed during the install phase, a few of which were previously omitted). Subject: kdeextragear-2/kst CVS commit by staikos: add more files to the rpm CCMAIL: 67607-done@bugs.kde.org M +15 -0 kst.spec.in 1.16 --- kdeextragear-2/kst/kst.spec.in #1.15:1.16 @@ -14,4 +14,6 @@ BuildRoot: /var/tmp/kst-%{version}.root +Requires(post,postun): /sbin/ldconfig + %description A data viewing application for KDE. @@ -28,4 +30,5 @@ %files +%defattr(-,root,root) #binaries %prefix/bin/kst @@ -44,4 +47,14 @@ %prefix/share/services/kst/kstdata_planck.desktop %prefix/lib/kde3/kstdata_planck.so +%prefix/include/kstdatasource.h +%prefix/include/kstobject.h +%prefix/lib/kde3/kstdata_ascii.la +%prefix/lib/kde3/kstdata_dirfile.la +%prefix/lib/kde3/kstdata_frame.la +%prefix/lib/kde3/kstdata_indirect.la +%prefix/lib/kde3/kstdata_planck.la +%prefix/lib/libkst.la +%prefix/share/servicetypes/kst/kstdatasourceplugin.desktop +%prefix/share/servicetypes/kst/kstplugin.desktop # UI file %prefix/share/apps/kst/kstui.rc @@ -74,5 +87,7 @@ %post +/sbin/ldconfig %postun +/sbin/ldconfig |