Summary: | support NorthEastGravity for resizing, needed for RTL languages | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Diego Iastrubni <cuco3001> |
Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | qt3 patch |
Description
Diego Iastrubni
2003-09-26 10:57:06 UTC
Subject: kdebase/kwin CVS commit by lunakl: Looks like I got window gravities working correctly also for configure requests. CCMAIL: 64981-done@bugs.kde.org M +11 -11 client.cpp 1.377 M +11 -10 client.h 1.109 M +95 -60 geometry.cpp 2.13 M +2 -1 manage.cpp 2.6 M +4 -0 utils.h 2.2 M +21 -7 tools/test_gravity.cpp 1.3 Using SVN from 15-10-2005, I can confirm a regression. To reproduce: Open Konqueror in RTL mode (konqueror --reverse) Open the settings menu Open the each part of that window. Some part should resize the window to the left, and on my setup I see the window resized to the right. This worked back in KDE 3.2, and I am almost sure it worked for 3.3. For some reason I see it does not work for 3.5 and 3.4 (!), funny how I missed that... It seems that Qt has support for this (qwidget_x11.cpp, QWidget::create() arround line 599) and it seems kwin has support for it... well, enjoy :) Is it ok to promote this to a bug? or would you like me to open another bug for this? Reopening. There seems to be still a bug in Qt and it seems to have been there since ever. I seem to remember you reported this also to TT, am I right? If that's the case please check the status of your bugreport. The attached patch should fix the problem for Qt3.x, for Qt4.x the fix is very similar. Created attachment 13023 [details]
qt3 patch
are you sure this one works? this is a static variable, which is not in any class, gets it's value when the application is created, but only the QApplication reversed it's layout. This means (I did not test it yet, I will have to admin) it should not work always. I will report a new but to the trolls, as I dont have the number of the old bug. __________________________________ Start your day with Yahoo! - Make it your home page! http://www.yahoo.com/r/hs Yes, I'm quite sure it works. I opened this as N90090 in the trolls bug system, the reply I got from Jan Erik Hanssen was: "So it seems, this was fixed for most cases but we still use NorthWestGravity in the do_size_hints() function both in Qt 3 and 4. We'll try to fix this for a future release, thanks for reporting." Up to TT to fix this. wait... before you close it, can you wait until we have a tested patch in qt-copy? I will try and test qt-copy this weekend. __________________________________ Yahoo! Mail - PC Magazine Editors' Choice 2005 http://mail.yahoo.com I'm quite confident the patch is correct. Moreover I thought you attached the patch to the bugreport to TT, so it's up to them to fix the problem, be it using this patch or some other way. And anyway, if there's still something to do, closed bugreports can be always reopened again. |