Bug 64981 - support NorthEastGravity for resizing, needed for RTL languages
Summary: support NorthEastGravity for resizing, needed for RTL languages
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-26 10:57 UTC by Diego Iastrubni
Modified: 2005-11-07 22:00 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
qt3 patch (525 bytes, patch)
2005-10-17 14:47 UTC, Lubos Lunak
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Iastrubni 2003-09-26 10:57:06 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources

Quotnig what Lubos Lunak <l.lunak@suse.cz> wrote, this will be descriptive enough :)

"But I still don't quite understand the problem. Guessing based on your cvs 
commit comment, the problem is that with reverse layouts, windows should 
resize to the left, instead of right? I.e. with LTR, the northwest (i.e. 
topleft) corner should stay, while with RTL, the northeast cornet should be 
the corner that doesn't move?"

"You can start by entering a new bugreport at bugs.kde.org. I'll have already 
a bunch of things to do for KDE3.2, but maybe this will get high enough 
priority. Having a reminder at bugs.kde.org will definitely help it. Just say 
something like 'support NorthEastGravity for resizing, needed for RTL 
languages'."
Comment 1 Lubos Lunak 2003-10-01 13:45:07 UTC
Subject: kdebase/kwin

CVS commit by lunakl: 

Looks like I got window gravities working correctly also for configure requests.
CCMAIL: 64981-done@bugs.kde.org


  M +11 -11    client.cpp   1.377
  M +11 -10    client.h   1.109
  M +95 -60    geometry.cpp   2.13
  M +2 -1      manage.cpp   2.6
  M +4 -0      utils.h   2.2
  M +21 -7     tools/test_gravity.cpp   1.3



Comment 2 Diego Iastrubni 2005-10-15 00:45:06 UTC
Using SVN from 15-10-2005, I can confirm a regression. 

To reproduce:

Open Konqueror in RTL mode (konqueror --reverse)
Open the settings menu
Open the each part of that window.

Some part should resize the window to the left, and on my setup I see the window resized to the right. This worked back in KDE 3.2, and I am almost sure it worked for 3.3. For some reason I see it does not work for 3.5 and 3.4 (!), funny how I missed that...

It seems that Qt has support for this (qwidget_x11.cpp, QWidget::create() arround line 599) and it seems kwin has support for it... well, enjoy :)

Is it ok to promote this to a bug? or would you like me to open another bug for this?
Comment 3 Lubos Lunak 2005-10-17 14:45:47 UTC
Reopening.
Comment 4 Lubos Lunak 2005-10-17 14:47:22 UTC
There seems to be still a bug in Qt and it seems to have been there since ever. I seem to remember you reported this also to TT, am I right? If that's the case please check the status of your bugreport. The attached patch should fix the problem for Qt3.x, for Qt4.x the fix is very similar.
Comment 5 Lubos Lunak 2005-10-17 14:47:48 UTC
Created attachment 13023 [details]
qt3 patch
Comment 6 Diego Iastrubni 2005-10-18 20:11:47 UTC
are you sure this one works?
this is a static variable, which is not in any class,
gets it's value when the application is created, but
only the QApplication reversed it's layout. This means
(I did not test it yet, I will have to admin) it
should not work always. 

I will report a new but to the trolls, as I dont have
the number of the old bug. 


		
__________________________________ 
Start your day with Yahoo! - Make it your home page! 
http://www.yahoo.com/r/hs
Comment 7 Lubos Lunak 2005-10-27 16:29:33 UTC
Yes, I'm quite sure it works.
Comment 8 Diego Iastrubni 2005-11-05 16:34:13 UTC
I opened this as N90090 in the trolls bug system, the reply I got from Jan Erik Hanssen was:

"So it seems, this was fixed for most cases but we still use
NorthWestGravity in the do_size_hints() function both in Qt 3 and 4.
We'll try to fix this for a future release, thanks for reporting."
Comment 9 Lubos Lunak 2005-11-07 14:24:28 UTC
Up to TT to fix this.
Comment 10 Diego Iastrubni 2005-11-07 20:53:38 UTC
wait... before you close it, can you wait until we
have a tested patch in qt-copy? I will try and test
qt-copy this weekend.


	
		
__________________________________ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com
Comment 11 Lubos Lunak 2005-11-07 22:00:32 UTC
I'm quite confident the patch is correct. Moreover I thought you attached the patch to the bugreport to TT, so it's up to them to fix the problem, be it using this patch or some other way.
And anyway, if there's still something to do, closed bugreports can be always reopened again.