Summary: | Jumping to Unread messages when selecting a folder | ||
---|---|---|---|
Product: | [Applications] kmail | Reporter: | Patrick Huber <phuber> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED DUPLICATE | ||
Severity: | wishlist | CC: | bjoern |
Priority: | NOR | ||
Version: | 1.4.3 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Not Mark Read at Folder Change patch for 3.2.3 |
Description
Patrick Huber
2002-10-26 19:19:13 UTC
there's a "jump to first unread message" option in kde 3.1, i guess this is what you want. Subject: Re: Jumping to Unread messages when selecting a folder
On Sunday 10 November 2002 02:35, Daniel Naber wrote:
> there's a "jump to first unread message" option in kde
> 3.1, i guess this is what you want.
No. This one jumps to the wrong message. The submitter of the wish wants
the oldest new message to be selected when entering a folder and not
the topmost one. This is only relevant for people like him and me who
sort by Date ^ (i.e. newest message first).
Yes, I want this too. I want 'Jump to first READ message' selection. I sort messages by 'Date ^', use many folders and got MANY messages of different importance. So after check I go throught folders, look at headers (Subject/from) and choost the most urgent to read first, leaving not_so_important/personal/hobby/etc for later reading. Automatic marking as READ forces me to always set message as unread on folder change. This really sucks. I did made hack (Bug 22085: Don't mark as 'read' message opened when entering a folder), but configurating option is much better. It does not matter, if I got mail unchanged on enter or if I got highlited the newest already READ mail, both are good for me. (Also many friends of me uses my hack, because their reading style is similar) Created attachment 6991 [details]
Not Mark Read at Folder Change patch for 3.2.3
Here is my patch to version 3.2.3, it works without problem for me
Could you explain a bit further? From your patch title I am not convinced your patch would solve the problem. We are not interested in not marking stuff as read. The problem is that on folder change, depending on how the mail folder is sorted, the cursor jumps to the wrong message. We want it to jump to the right message AND mark it as read, as it should in fact now be showing in the message viewer. To reiterate, the problem crucially depends on how the folder is sorted. Some sorting methods will work correctly but others won't. You are right. My patch has nothing to do with sorting. My patch only disable "Mark as read" action in moment of changing folder. I was thinking, it is related also to this topic (rather than bug itself), because of users habit. Maybe I was wrong. (More about it is in closed Bug 22085:) Why isn't this a bug instead of a wishlist item? It is a misbehaviour in current functionality. The current code is not smart enough to handle all cases of folder sorting properly, so it jumps to the wrong mail when entering the folder. When a feature doesn't behave as expected, you have a bug. > It is a misbehaviour in current functionality. The current code is not
> smart enough to handle all cases of folder sorting properly, so it jumps to
> the wrong mail when entering the folder. When a feature doesn't behave as
> expected, you have a bug. _______________________________________________
It obviously behaves like most of the people expect it to. You want another
option as this shouldn't change the current way and this is a wish.
I don't think so. The implication of what you are saying is, that as long as most people are not affected by a particular problem, then effectively it is not a problem at all. The jump to message function behaves differently depending on which way the message list is sorted. That's wrong. It should behave the same no matter which way you sort the list. The relevant setup option can be found here: Setup->Configure KMail->Misc Here you can find the tickoff box which reads "Jump to first unread message when entering a folder". Weither you sort your mail folders in ascending or descending order, the message that is selected by this algorithm must be the same actual message. You know, this would be simple to fix actually. Just check which way the folder is sorted. If it is sorted ascendingly, use the current method. If it is sorted descendingly, reverse the search and start from the bottom of the list instead. It is that simple. And the proper title of this bug should read: "Reverse selection of unread mail when folder sorting is also reversed." If one was to try to fix this, which files and routines would be relevant to look at? It's a big application you know.. kmheaders.cpp, more precisely KMHeaders::readSortOrder(), I think. See also bug #117543 (esp. my second patch), which is touching the same code a bit. But one thing I wonder is: Should the last unread message be selected just when the sort order is "by date, newest first", or whenever messages are sorted in descending order, even by sender? I believe so. It should work the exactly opposide of the way ascending order works. *** This bug has been marked as a duplicate of bug 49575 *** |