Summary: | GHNS window opens in a new column rather than a new window | ||
---|---|---|---|
Product: | [Applications] plasma-systemmonitor | Reporter: | Nate Graham <nate> |
Component: | general | Assignee: | KSysGuard Developers <ksysguard-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ahiemstra, plasma-bugs |
Priority: | NOR | ||
Version: | 5.21.90 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-systemmonitor/commit/55fe372c6bdfabdd958795344ef4cf15ff548790 | Version Fixed In: | 5.22.1 |
Description
Nate Graham
2021-06-01 17:10:30 UTC
Huh, it should be pushing to the layer stack imo. This seems to have broken with the port to the GHNS actions. Yeah this seems to be a regression from the port to NewStuff.Action, which either should give the option to push to a layer or we need to completely drop using the page stack for those actions. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/143 Git commit 768f8ad5aab7698f550d601c36a4b922637231e4 by Dan Leinir Turthra Jensen. Committed on 08/06/2021 at 10:07. Pushed by leinir into branch 'master'. Push NewStuff pages to layers, not the stack The NewStuff.Action component will simply call the push function on whatever object it is given to work with as a page stack, and since the Kirigami pagestack layers also has one such, we can just switch to that. nb: The functionality is explicitly designed to work this way, to allow for things like the kcm pagestack to work as well as the more featureful Kirigami one. M +1 -1 src/main.qml M +2 -2 src/page/FaceConfigurationPage.qml https://invent.kde.org/plasma/plasma-systemmonitor/commit/768f8ad5aab7698f550d601c36a4b922637231e4 Git commit 55fe372c6bdfabdd958795344ef4cf15ff548790 by Nate Graham, on behalf of Dan Leinir Turthra Jensen. Committed on 08/06/2021 at 13:14. Pushed by ngraham into branch 'Plasma/5.22'. Push NewStuff pages to layers, not the stack The NewStuff.Action component will simply call the push function on whatever object it is given to work with as a page stack, and since the Kirigami pagestack layers also has one such, we can just switch to that. nb: The functionality is explicitly designed to work this way, to allow for things like the kcm pagestack to work as well as the more featureful Kirigami one. (cherry picked from commit 768f8ad5aab7698f550d601c36a4b922637231e4) M +1 -1 src/main.qml M +2 -2 src/page/FaceConfigurationPage.qml https://invent.kde.org/plasma/plasma-systemmonitor/commit/55fe372c6bdfabdd958795344ef4cf15ff548790 |