Bug 437961 - GHNS window opens in a new column rather than a new window
Summary: GHNS window opens in a new column rather than a new window
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: 5.21.90
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-01 17:10 UTC by Nate Graham
Modified: 2021-06-08 13:17 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-systemmonitor/commit/55fe372c6bdfabdd958795344ef4cf15ff548790
Version Fixed In: 5.22.1

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-06-01 17:10:30 UTC 
This is non-ideal for two reasons:

1. Inconsistency; nothing else does this
2. With a fairly wide window, the the main view is still partially visible in a left column, so the space for the GHNS column is quite limited, and the way that you get out of it (clicking the back button) feels awkward. And when you click on an item to look at it, that gets its own column too, partially cutting off the prior view.

Overall I would recommend just making the GHNS dialog a standalone window.
Comment 1 Arjen Hiemstra 2021-06-01 17:18:12 UTC 
Huh, it should be pushing to the layer stack imo. This seems to have broken with the port to the GHNS actions.
Comment 2 Arjen Hiemstra 2021-06-01 17:27:38 UTC 
Yeah this seems to be a regression from the port to NewStuff.Action, which either should give the option to push to a layer or we need to completely drop using the page stack for those actions.
Comment 3 Bug Janitor Service 2021-06-08 10:11:20 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/143
Comment 4 Dan Leinir Turthra Jensen 2021-06-08 10:32:05 UTC 
Git commit 768f8ad5aab7698f550d601c36a4b922637231e4 by Dan Leinir Turthra Jensen.
Committed on 08/06/2021 at 10:07.
Pushed by leinir into branch 'master'.

Push NewStuff pages to layers, not the stack

The NewStuff.Action component will simply call the push function on
whatever object it is given to work with as a page stack, and since the
Kirigami pagestack layers also has one such, we can just switch to that.

nb: The functionality is explicitly designed to work this way, to allow for
things like the kcm pagestack to work as well as the more featureful
Kirigami one.

M  +1    -1    src/main.qml
M  +2    -2    src/page/FaceConfigurationPage.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/768f8ad5aab7698f550d601c36a4b922637231e4
Comment 5 Nate Graham 2021-06-08 13:15:00 UTC 
Git commit 55fe372c6bdfabdd958795344ef4cf15ff548790 by Nate Graham, on behalf of Dan Leinir Turthra Jensen.
Committed on 08/06/2021 at 13:14.
Pushed by ngraham into branch 'Plasma/5.22'.

Push NewStuff pages to layers, not the stack

The NewStuff.Action component will simply call the push function on
whatever object it is given to work with as a page stack, and since the
Kirigami pagestack layers also has one such, we can just switch to that.

nb: The functionality is explicitly designed to work this way, to allow for
things like the kcm pagestack to work as well as the more featureful
Kirigami one.


(cherry picked from commit 768f8ad5aab7698f550d601c36a4b922637231e4)

M  +1    -1    src/main.qml
M  +2    -2    src/page/FaceConfigurationPage.qml

https://invent.kde.org/plasma/plasma-systemmonitor/commit/55fe372c6bdfabdd958795344ef4cf15ff548790