Summary: | Compacting this very mbox doesn't work | ||
---|---|---|---|
Product: | [Applications] kmail | Reporter: | Malte S . Stretz <msquadrat.nospamplease> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 1.4.1 | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Malte S . Stretz
2002-06-10 16:40:48 UTC
On Monday 10 June 2002 18:40 CET I wrote:
> Now that's weird: I can't compact my spam-folder anymore (iff it ever
> worked). [...] I can reproduce this both with moving and deleting
> messages but for this folder only.
Have to correct myself: I can reproduce this on my inbox too.
Malte
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Friday 14 June 2002 17:42 Malte S. Stretz wrote: > On Monday 10 June 2002 18:40 CET I wrote: > > Now that's weird: I can't compact my spam-folder anymore (iff it > > ever worked). [...] I can reproduce this both with moving and > > deleting messages but for this folder only. > > Have to correct myself: I can reproduce this on my inbox too. <snip> Do you have Compactable=false for these folders in kmailrc? See the FAQ on kmail.kde.org if that's the case. Marc - -- Marc Mutz <mutz@kde.org> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) iD8DBQE9CjOC3oWD+L2/6DgRAoyqAKDW/2YQV7WtqyG8Wv5CfXqyyJ6QqACfbMZs v8/JdNH8Lr59T2yI1AEenYU= =8Y8F -----END PGP SIGNATURE----- On Friday 14 June 2002 20:18 CET Marc Mutz wrote: > On Friday 14 June 2002 17:42 Malte S. Stretz wrote: > > On Monday 10 June 2002 18:40 CET I wrote: > > > Now that's weird: I can't compact my spam-folder anymore (iff it > > > ever worked). [...] I can reproduce this both with moving and > > > deleting messages but for this folder only. > > > > Have to correct myself: I can reproduce this on my inbox too. > > Do you have Compactable=false for these folders in kmailrc? > See the FAQ on kmail.kde.org if that's the case. Nope: | [Folder-.Empfangene Nachrichten.directory/9: UBE] | Compactable=true | Current=248 | DateWidth=170 | ExpireMessages=false | Identity= | MailingListAdminAddress= | MailingListEnabled=false | MailingListPostingAddress= | OrderOfArrival=true | ReadExpireAge=3 | ReadExpireUnits=3 | SenderWidth=170 | SizeWidth=80 | SortColumn=-3 | Status=false | SubjectWidth=310 | Top=242 | UnreadExpireAge=12 | UnreadExpireUnits=0 | UnreadMsgs=0 | WhoField= | htmlMailOverride=false | isOpen=true | threadMessagesOverride=false Malte Malte: can you still reproduce it with CVS? The host name doesn't resolve. Yeah, sorry. Had to shut the web server down on that machine. I copied it moved it somewhere else [2]. As I didn't get current CVS to compile yet I didn't have a chance to test it though :-( [2]http://stretz.eu.org/pub/bugaboo/ube.tar.bz2 this bug seems to be duplicate of #39290; please check my comment there. Subject: kdepim/kmail CVS commit by tilladam: Handle empty lines before the first mbox delimiter gracefully. This fixes compaction of notoriously non-compactible mboxes. Don't reset the needCompacting flag until the compaction has actually suceeded. CCMAIL: 39290-done@bugs.kde.org CCMAIL: 43773-done@bugs.kde.org One cookie my way, please. M +2 -2 kmfoldermbox.cpp 1.91 --- kdepim/kmail/kmfoldermbox.cpp #1.90:1.91 @@ -1156,5 +1156,5 @@ int KMFolderMbox::compact() fread(mtext.data(), 20, 1, mStream); if(i <= 0) { //woops we've reached the top of the file, last try.. - if(!strncasecmp(mtext.data(), "from ", 5)) { + if ( mtext.contains( "from ", false ) ) { if (mtext.size() < (size_t)folder_offset) mtext.resize(folder_offset); @@ -1222,4 +1222,5 @@ int KMFolderMbox::compact() close(true); mAutoCreateIndex = autoCreate; + needsCompact = false; // We are clean now } else @@ -1237,5 +1238,4 @@ int KMFolderMbox::compact() } emit changed(); - needsCompact = false; // We are clean now return 0; |