Bug 43773 - Compacting this very mbox doesn't work
Summary: Compacting this very mbox doesn't work
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: general (show other bugs)
Version: 1.4.1
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-06-10 16:48 UTC by Malte S . Stretz
Modified: 2007-09-14 12:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Malte S . Stretz 2002-06-10 16:40:48 UTC
(*** This bug was imported into bugs.kde.org ***)

Package:           kmail
Version:           1.4.1 (using KDE 3.0.1 )
Severity:          normal
Installed from:    SuSE
Compiler:          gcc version 2.95.3 20010315 (SuSE)
OS:                Linux (i686) release 2.4.18
OS/Compiler notes: 

Now that's weird: I can't compact my spam-folder anymore (iff it ever worked). According to KMail it contains 250 messages. `grep '^From ' ube.mbox | wc -l` gives me 516 messages. Look at the message msgid:3D00FD25.90406@perkel.com for an example. I can reproduce this both with moving and deleting messages but for this folder only.

Locally this folder is found there (shell quoting):
"~/.Mail/.Empfangene Nachrichten.directory/9: UBE"
I've got a folder "[...]/8: eBay" there too (with 3 messages) which is compacted perfectly.

I know that I moved the message msgid:E16Vda7-0000bU-00@dozer out of the folder shortly after I received it and I still used KMail from KDE 2.2.0 that time around.

Have a look at the mbox file at [1].

Malte

[1]http://dyn.msquadrat.de/pub/bugaboo/ube.tar.bz2

(Submitted via bugs.kde.org)
(Called from KBugReport dialog)
Comment 1 Malte S . Stretz 2002-06-14 15:42:36 UTC
On Monday 10 June 2002 18:40 CET I wrote:
> Now that's weird: I can't compact my spam-folder anymore (iff it ever
> worked). [...] I can reproduce this both with moving and deleting
> messages but for this folder only.

Have to correct myself: I can reproduce this on my inbox too.

Malte
Comment 2 Marc Mutz 2002-06-14 18:18:32 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 14 June 2002 17:42 Malte S. Stretz wrote:
> On Monday 10 June 2002 18:40 CET I wrote:
> > Now that's weird: I can't compact my spam-folder anymore (iff it
> > ever worked). [...] I can reproduce this both with moving and
> > deleting messages but for this folder only.
>
> Have to correct myself: I can reproduce this on my inbox too.
<snip>

Do you have Compactable=false for these folders in kmailrc?
See the FAQ on kmail.kde.org if that's the case.

Marc

- -- 
Marc Mutz <mutz@kde.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9CjOC3oWD+L2/6DgRAoyqAKDW/2YQV7WtqyG8Wv5CfXqyyJ6QqACfbMZs
v8/JdNH8Lr59T2yI1AEenYU=
=8Y8F
-----END PGP SIGNATURE-----
Comment 3 Malte S . Stretz 2002-06-14 19:03:59 UTC
On Friday 14 June 2002 20:18 CET Marc Mutz wrote:
> On Friday 14 June 2002 17:42 Malte S. Stretz wrote:
> > On Monday 10 June 2002 18:40 CET I wrote:
> > > Now that's weird: I can't compact my spam-folder anymore (iff it
> > > ever worked). [...] I can reproduce this both with moving and
> > > deleting messages but for this folder only.
> >
> > Have to correct myself: I can reproduce this on my inbox too.
>
> Do you have Compactable=false for these folders in kmailrc?
> See the FAQ on kmail.kde.org if that's the case.

Nope:
| [Folder-.Empfangene Nachrichten.directory/9: UBE]
| Compactable=true
| Current=248
| DateWidth=170
| ExpireMessages=false
| Identity=
| MailingListAdminAddress=
| MailingListEnabled=false
| MailingListPostingAddress=
| OrderOfArrival=true
| ReadExpireAge=3
| ReadExpireUnits=3
| SenderWidth=170
| SizeWidth=80
| SortColumn=-3
| Status=false
| SubjectWidth=310
| Top=242
| UnreadExpireAge=12
| UnreadExpireUnits=0
| UnreadMsgs=0
| WhoField=
| htmlMailOverride=false
| isOpen=true
| threadMessagesOverride=false

Malte
Comment 4 Stephan Kulow 2003-09-21 12:14:23 UTC
Malte: can you still reproduce it with CVS? The host name doesn't resolve. 
Comment 5 Malte S. Stretz 2003-09-22 19:13:07 UTC
Yeah, sorry. Had to shut the web server down on that machine. I copied it 
moved it somewhere else [2]. As I didn't get current CVS to compile yet I 
didn't have a chance to test it though :-( 
 
[2]http://stretz.eu.org/pub/bugaboo/ube.tar.bz2 
Comment 6 noster 2003-11-05 20:50:59 UTC
this bug seems to be duplicate of #39290;
please check my comment there.
Comment 7 Till Adam 2003-12-28 01:15:27 UTC
Subject: kdepim/kmail

CVS commit by tilladam: 

Handle empty lines before the first mbox delimiter gracefully. This fixes
compaction of notoriously non-compactible mboxes.

Don't reset the needCompacting flag until the compaction has actually
suceeded.

CCMAIL: 39290-done@bugs.kde.org
CCMAIL: 43773-done@bugs.kde.org

One cookie my way, please.


  M +2 -2      kmfoldermbox.cpp   1.91


--- kdepim/kmail/kmfoldermbox.cpp  #1.90:1.91
@@ -1156,5 +1156,5 @@ int KMFolderMbox::compact()
       fread(mtext.data(), 20, 1, mStream);
       if(i <= 0) { //woops we've reached the top of the file, last try..
-        if(!strncasecmp(mtext.data(), "from ", 5)) {
+        if ( mtext.contains( "from ", false ) ) {
           if (mtext.size() < (size_t)folder_offset)
               mtext.resize(folder_offset);
@@ -1222,4 +1222,5 @@ int KMFolderMbox::compact()
     close(true);
     mAutoCreateIndex = autoCreate;
+    needsCompact = false;             // We are clean now
   }
   else
@@ -1237,5 +1238,4 @@ int KMFolderMbox::compact()
   }
   emit changed();
-  needsCompact = false;             // We are clean now
   return 0;