Summary: | "Change wallpaper" sheet remains open after selecting a new image | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | Michael <michael.hmich> |
Component: | kcm_sddm | Assignee: | David Edmundson <kde> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | bugseforuns, kde, nate, plasma-bugs |
Priority: | NOR | Keywords: | regression, usability |
Version: | 5.21.2 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/sddm-kcm/commit/f4e241d7e173093918dcb2b7674320de026560fd | Version Fixed In: | 5.23 |
Description
Michael
2021-03-03 19:53:56 UTC
That's how it supposed to work? To close the sheet you can also just click beside it We should probably close the sheet automatically after the user selects a new image. Otherwise it's just a manual chore. that is most likely not how it is supposed to work, instead of your funny comments you could be a little bit more serious and asked when it was not clear enough ... the select background image dialog has the new selected image then there is no confirm option and also no close option, so you keep with the only possibility and close the box with X ... but then the image is not selected It's selected, it will just be applied with the rest of the changes when "Apply" is pressed. A possibly relevant merge request was started @ https://invent.kde.org/plasma/sddm-kcm/-/merge_requests/14 Git commit f4e241d7e173093918dcb2b7674320de026560fd by Nate Graham. Committed on 16/06/2021 at 16:14. Pushed by ngraham into branch 'master'. Close sheets after successfully interacting with them Currently when you use any of the buttons in the KCM's sheets, they awkwardly stay open afterwards, leaving you wondering if the thing you did worked. Instead, let's close them after a successful operation. Related: bug 436137 FIXED-IN: 5.23 M +17 -2 src/package/contents/ui/main.qml M +2 -0 src/sddmkcm.cpp M +2 -0 src/sddmkcm.h https://invent.kde.org/plasma/sddm-kcm/commit/f4e241d7e173093918dcb2b7674320de026560fd |