Bug 433919 - "Change wallpaper" sheet remains open after selecting a new image
Summary: "Change wallpaper" sheet remains open after selecting a new image
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_sddm (show other bugs)
Version: 5.21.2
Platform: Neon Linux
: NOR minor
Target Milestone: ---
Assignee: David Edmundson
URL:
Keywords: regression, usability
Depends on:
Blocks:
 
Reported: 2021-03-03 19:53 UTC by Michael
Modified: 2022-09-23 03:14 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.23


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael 2021-03-03 19:53:56 UTC
after choosing the theme the background image is white
changing the bg-image by choosing the hover "change background option" another dialog appears to select a file which then is appearing as background f this dialog box but there is no confirm/apply button, also no cancel button, so the only way to get out is the box's X
another try to see if I did something wrong, beside that the dialog box is blocking (stays on top) I can click the apply button of the sddm theme chooser window what then applies the selected image as login background image

System:    Host: hm-mint Kernel: 5.11.2-hmich-tl-frt-2.45 x86_64 bits: 64 
           Desktop: KDE Plasma 5.21.2 Distro: Linux Mint 20.1 Ulyssa
Comment 1 David Redondo 2021-03-04 07:46:16 UTC
That's how it supposed to work? To close the sheet you can also just click beside it
Comment 2 Nate Graham 2021-03-04 17:23:14 UTC
We should probably close the sheet automatically after the user selects a new image. Otherwise it's just a manual chore.
Comment 3 Michael 2021-03-04 21:31:11 UTC
that is most likely not how it is supposed to work, instead of your funny comments you could be a little bit more serious and asked when it was not clear enough ...

the select background image dialog has the new selected image then there is no confirm option and also no close option, so you keep with the only possibility and close the box with X ... but then the image is not selected
Comment 4 David Redondo 2021-03-05 07:47:47 UTC
It's selected, it will just be applied with the rest of the changes when "Apply" is pressed.
Comment 5 Bug Janitor Service 2021-06-16 16:16:56 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/sddm-kcm/-/merge_requests/14
Comment 6 Nate Graham 2021-06-17 13:54:57 UTC
Git commit f4e241d7e173093918dcb2b7674320de026560fd by Nate Graham.
Committed on 16/06/2021 at 16:14.
Pushed by ngraham into branch 'master'.

Close sheets after successfully interacting with them

Currently when you use any of the buttons in the KCM's sheets, they
awkwardly stay open afterwards, leaving you wondering if the thing you
did worked. Instead, let's close them after a successful operation.
Related: bug 436137
FIXED-IN: 5.23

M  +17   -2    src/package/contents/ui/main.qml
M  +2    -0    src/sddmkcm.cpp
M  +2    -0    src/sddmkcm.h

https://invent.kde.org/plasma/sddm-kcm/commit/f4e241d7e173093918dcb2b7674320de026560fd