Bug 330037

Summary:	Tweets marked favorite from Choqok are not listed on Favorite Folder
Product:	[Applications] choqok	Reporter:	Ricardo Chung <ricardo.a.chung>
Component:	Twitter	Assignee:	Daniel Kreuter <daniel.kreuter85>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mehrdad.momeny, ricardo.a.chung, scarpino
Priority:	NOR
Version:	1.4
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	a93ae8bbd965d5e10c3088c8e94b1bc595037e48	Version Fixed In:	1.5

Description Ricardo Chung 2014-01-16 15:12:04 UTC

Tweet marked favorite from Choqok is not listed on the Choqok's Favorite Folder. It shows Favorite Mark highlighted.  

Tweet marked favorite from other twitter clients (e.g. smartphone, tablet) is listed on Choqok's Favorite Folder. It shows Favorite Mark highlighted.


Reproducible: Always

Steps to Reproduce:
1.On Choqok, select a tweet and mark Favorite
2.Browse into Choqok's Favorite Folder
3.Tweet marked Favorite is not showed
Actual Results:  
twitter.com doesn't show favorite marker from tweets marked in Chokoq.
Choqok shows favorite marker from tweets marked in Twitter or Twitter App.


Expected Results:  
Choqok used to show favorite marker and favorite tweets on Favorite Folder.

There is a similar bug on Choqok version 1.3 https://bugs.kde.org/show_bug.cgi?id=321328 focused only on Choqok missing feature. 

On Choqok version 1.4 it looks like it's only not able to send the Favorite Marker to the server.

Comment 1 Daniel Kreuter 2014-01-16 18:37:23 UTC

Hi,

by reading the peace of code responsible for the favorites I found the reason why it's not working. I will provide a fix later this day on reviewboard.

Best regards

Daniel

Comment 2 Daniel Kreuter 2014-01-16 21:25:20 UTC

Hi again,

patch is currently on reviewboard. Fixed creating of favorites as well as deleting them.

Best regards

Comment 3 Daniel Kreuter 2014-01-17 17:02:31 UTC

Git commit a93ae8bbd965d5e10c3088c8e94b1bc595037e48 by Daniel Kreuter.
Committed on 16/01/2014 at 21:15.
Pushed by dkreuter into branch 'master'.

Fixing twitter favorites.

Fixed creating / destroying of twitter favorite tweets.

M  +17   -10   helperlibs/twitterapihelper/twitterapimicroblog.cpp

http://commits.kde.org/choqok/a93ae8bbd965d5e10c3088c8e94b1bc595037e48

Comment 4 Daniel Kreuter 2014-01-17 17:03:14 UTC

Bugfix has been committed to the master branch --> closed.