Bug 317509

Summary:	Add option to set "" instead of NULL for CSV Import
Product:	[Applications] KEXI	Reporter:	Tomasz Olszak <olszak.tomasz>
Component:	Migration/Import/Export	Assignee:	Tomasz Olszak <olszak.tomasz>
Status:	CLOSED FIXED
Severity:	normal	CC:	staniek
Priority:	NOR
Version:	unspecified
Target Milestone:	2.7
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/a16c3baa70ade1eebb323c755718cf1756f3a0c1	Version Fixed In:
Bug Depends on:
Bug Blocks:	313695

Description Tomasz Olszak 2013-03-28 22:13:24 UTC

Set "" for text columns instead of NULL in CSV Import by default.
Add option in csv import dialog:
"Import missing text values as empty texts". Option is available under "Configure..." button.
Option should be saved in ImportNULLsAsEmptyText variable and described in kexi/doc/dev/settings.txt

Reproducible: Always

Comment 1 Jarosław Staniek 2013-03-31 18:44:38 UTC

@tomasz thanks but please do not set it resolved - only set RESOLVED, then CLOSED after the actual commit (in this case to master i.e. 2.7).
Do that using the BUG:xxxxxx line in the _final_ commit message after you get the review, thanks.

Comment 2 Tomasz Olszak 2013-04-17 16:33:50 UTC

Git commit a16c3baa70ade1eebb323c755718cf1756f3a0c1 by Tomasz Olszak.
Committed on 15/04/2013 at 22:35.
Pushed by tolszak into branch 'master'.

Kexi - By default missing CSV values imported as empty texts.

Now user can choose to import missing texts as empty text values
(current default configuration) or as NULLs (previous behavior) to
destination table. There was a lot of confusion when SQL queries with
condition columnName = '' did not show any results for imported data.
REVIEW: 109806

M  +3    -0    kexi/doc/dev/settings.txt
M  +14   -3    kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
M  +11   -2    kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.cpp
M  +4    -2    kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.h

http://commits.kde.org/calligra/a16c3baa70ade1eebb323c755718cf1756f3a0c1

Comment 3 Tomasz Olszak 2013-04-17 16:33:50 UTC

Git commit a16c3baa70ade1eebb323c755718cf1756f3a0c1 by Tomasz Olszak.
Committed on 15/04/2013 at 22:35.
Pushed by tolszak into branch 'master'.

Kexi - By default missing CSV values imported as empty texts.

Now user can choose to import missing texts as empty text values
(current default configuration) or as NULLs (previous behavior) to
destination table. There was a lot of confusion when SQL queries with
condition columnName = '' did not show any results for imported data.
REVIEW: 109806

M  +3    -0    kexi/doc/dev/settings.txt
M  +14   -3    kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
M  +11   -2    kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.cpp
M  +4    -2    kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.h

http://commits.kde.org/calligra/a16c3baa70ade1eebb323c755718cf1756f3a0c1