| Summary: | [JJ] GHNS button displays icon, even if disabled in style settings | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Christoph Feck <cfeck> |
| Component: | compositing | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | Keywords: | junior-jobs |
| Priority: | NOR | Flags: | mgraesslin:
ReviewRequest+
|
| Version: | git master | ||
| Target Milestone: | 4.11 | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| URL: | https://git.reviewboard.kde.org/r/108286/ | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/366ea1e7e76f75e82209ebf412a265553451cfa0 | Version Fixed In: | 4.11 |
|
Description
Christoph Feck
2012-11-08 01:16:51 UTC
Additionally, the button text should be "Get New Effects ...", not "Get New Effect" to make it consistent with the rest of KDE. On the other hand, there is only one effect to get, so the button is right. (SCNR) While at it: the button should probably in line with the search ______________________________ ====== ------------------------------------------------- | | | | | | ------------------------------------------------- === === === Git commit 366ea1e7e76f75e82209ebf412a265553451cfa0 by Martin Gräßlin. Committed on 09/01/2013 at 08:30. Pushed by graesslin into branch 'master'. Use KPushButton for GHNS in Effects KCM Also rename to proper name "Get New Effects ...". FIXED-IN: 4.11 REVIEW: 108286 M +8 -3 kwin/kcmkwin/kwincompositing/main.ui http://commits.kde.org/kde-workspace/366ea1e7e76f75e82209ebf412a265553451cfa0 |