Summary: | [JJ] Some effect authors are listed as "Name1 & Name2" | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Christoph Feck <cfeck> |
Component: | effects-various | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | Keywords: | junior-jobs |
Priority: | NOR | Flags: | mgraesslin:
ReviewRequest+
|
Version: | git master | ||
Target Milestone: | 4.10 | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
URL: | https://git.reviewboard.kde.org/r/106880/ | ||
Latest Commit: | http://commits.kde.org/kde-workspace/ace3782a0e73e045de9d833797ef19c9b73e18e7 | Version Fixed In: | 4.10 |
Description
Christoph Feck
2012-10-05 15:25:50 UTC
the author information is taken from the desktop file. Any idea how to properly specify multiple authors there? s/ & /, /g (see fade/metadata.desktop) (In reply to comment #2) > s/ & /, /g > > (see fade/metadata.desktop) In the hope that the community can take care of it: What Christoph wrote is "sed" syntax which just says that the & should be replace by a , So if the .dekstop file lists: Foo & Bar It has to become: Foo, Bar The errors are in .desktop files in the kwin/effects/ subdirectories of the kde-workspace git repository. *never* do what the machine can do for you ;-) find -name "*.desktop" -exec sed -ie 's/\(X-KDE-PluginInfo-Email=.*\)\s\{1,\}&\s*\(.*\)/\1, \2/g' '{}' + find -name "*.desktop" -exec sed -ie 's/\(X-KDE-PluginInfo-Author=.*\)\s\{1,\}&\s*\(.*\)/\1, \2/g' '{}' + to just check find -name "*.desktop" -exec sed -e 's/\(X-KDE-PluginInfo-Email=.*\)\s\{1,\}&\s*\(.*\)/\1, \2/g' '{}' + | grep -E 'X-KDE-PluginInfo-(Email|Author)' Git commit ace3782a0e73e045de9d833797ef19c9b73e18e7 by Martin Gräßlin, on behalf of Alexander Jones. Committed on 15/10/2012 at 17:02. Pushed by graesslin into branch 'master'. Fixing author names in desktop files FIXED-IN: 4.10 REVIEW: 106880 M +2 -2 kwin/effects/desktopgrid/desktopgrid.desktop M +2 -2 kwin/effects/invert/invert.desktop M +2 -2 kwin/effects/logout/logout.desktop M +2 -2 kwin/effects/presentwindows/presentwindows.desktop M +2 -2 kwin/effects/zoom/zoom.desktop http://commits.kde.org/kde-workspace/ace3782a0e73e045de9d833797ef19c9b73e18e7 |