Summary: | theme parsing errors (gtk-warning) | ||
---|---|---|---|
Product: | [Plasma] Oxygen | Reporter: | Philip Muškovac <yofel> |
Component: | gtk2-engine | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
Status: | CLOSED FIXED | ||
Severity: | normal | CC: | b7.10110111, hugo.pereira.da.costa, web |
Priority: | LO | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Philip Muškovac
2012-02-08 19:35:07 UTC
Will wait for gtk 3.3 to become Gtk3's "stable" release for fixing. (since everything changes from one version to the other, which I am not so happy with), and also since trying to install it here totally breaks my system (due to the required glib update, which apparently has issues with g_mutex_unlock). I've tried installing GTK 3.3, and it appears to have some even more important issues, i.e. visual ones. I start to suspect that we might have to wait much longer for GTK3 to stabilize than one major release... Anyway, I can reproduce this problem, and I think it's easy to fix. Git commit 0daca58264a453eb895cfd64a15e5e9ba93081ca by Ruslan Kabatsayev. Committed on 08/02/2012 at 22:08. Pushed by kabatsayev into branch 'gtk3'. Add px units to all numbers in gtk.css M +50 -50 rc/gtk.css M +2 -2 src/oxygenqtsettings.cpp http://commits.kde.org/oxygen-gtk/0daca58264a453eb895cfd64a15e5e9ba93081ca The above commit removes most of the warnings, namely those which are generated because of gtk.css *file*. There remains one error message, which originates from dynamically-generated css data. @Hugo, I guess this is somewhere in oxygengtkcss.h, maybe in CSSOption(). I'm not sure in this, and you should know this code better, so I leave this one for you. Git commit 6d42cabbf6025fba4cff4ef9cea584574eda02ca by Hugo Pereira Da Costa. Committed on 13/02/2012 at 10:51. Pushed by hpereiradacosta into branch 'gtk3'. added missing unit for "padding" option. M +1 -1 src/oxygenqtsettings.cpp http://commits.kde.org/oxygen-gtk/6d42cabbf6025fba4cff4ef9cea584574eda02ca Ruslan ? Can you test that the above fixes the remaining warnings ? (I can't: back to gtk3.2) If yes, please close There is one remaining place where there might be warnings. It concerns the font sizes (namely things like: GtkMenuItem { font: Helvetica 8; } GtkToolbar { font: Helvetica 8; } But I'm not sure whether unit is needed (or even accepted) here. So please double check. Thanks in advance, Hugo PS: we'll need to backport this change, and possibly the ones on icons background to gtk3-1.0 (for which there should be a release in a couple of days). Git commit 046ef1c6f888eb69887aa8df75f2be69c3fff8d3 by Hugo Pereira Da Costa, on behalf of Ruslan Kabatsayev. Committed on 08/02/2012 at 22:08. Pushed by hpereiradacosta into branch 'gtk3-1.0'. Add px units to all numbers in gtk.css M +50 -50 rc/gtk.css M +2 -2 src/oxygenqtsettings.cpp http://commits.kde.org/oxygen-gtk/046ef1c6f888eb69887aa8df75f2be69c3fff8d3 Git commit 50c181314d7b090f4b4f0c7e6e42fadb37f69f69 by Hugo Pereira Da Costa. Committed on 13/02/2012 at 10:51. Pushed by hpereiradacosta into branch 'gtk3-1.0'. added missing unit for "padding" option. M +1 -1 src/oxygenqtsettings.cpp http://commits.kde.org/oxygen-gtk/50c181314d7b090f4b4f0c7e6e42fadb37f69f69 Fixed. |