Bug 293668 - theme parsing errors (gtk-warning)
Summary: theme parsing errors (gtk-warning)
Status: CLOSED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: gtk2-engine (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: LO normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-08 19:35 UTC by Philip Muškovac
Modified: 2012-05-15 04:07 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Muškovac 2012-02-08 19:35:07 UTC
Version:           unspecified (using KDE 4.8.0) 
OS:                Linux

When running oxygen-gtk3 1.0.0 on Kubuntu Precise and starting a gnome app in a terminal, I get:

Gtk-WARNING **: Theme parsing error: <unknown>:74:12: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:73:35: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:102:14: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:102:16: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:107:14: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:110:35: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:110:37: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:111:32: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:111:34: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:112:41: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:112:43: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:122:24: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:125:28: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:128:30: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:131:21: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:132:30: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:133:24: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:137:24: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:138:33: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:140:14: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:140:16: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:143:41: Not using units is deprecated. Assuming 'px'.

Gtk-WARNING **: Theme parsing error: gtk.css:144:37: Not using units is deprecated. Assuming 'px'.


Reproducible: Always

Steps to Reproduce:
run a gnome app like evince from Konsole

Actual Results:  
lots of theme errors

Expected Results:  
no theme errors

libgtk 3.3.14-0ubuntu1
Comment 1 Hugo Pereira Da Costa 2012-02-08 20:30:16 UTC
Will wait for gtk 3.3 to become Gtk3's "stable" release for fixing.
(since everything changes from one version to the other, which I am not so happy with), and also since trying to install it here totally breaks my system (due to the required glib update, which apparently has issues with g_mutex_unlock).
Comment 2 Ruslan Kabatsayev 2012-02-08 20:47:54 UTC
I've tried installing GTK 3.3, and it appears to have some even more important issues, i.e. visual ones. I start to suspect that we might have to wait much longer for GTK3 to stabilize than one major release...

Anyway, I can reproduce this problem, and I think it's easy to fix.
Comment 3 Ruslan Kabatsayev 2012-02-08 21:09:06 UTC
Git commit 0daca58264a453eb895cfd64a15e5e9ba93081ca by Ruslan Kabatsayev.
Committed on 08/02/2012 at 22:08.
Pushed by kabatsayev into branch 'gtk3'.

Add px units to all numbers in gtk.css

M  +50   -50   rc/gtk.css
M  +2    -2    src/oxygenqtsettings.cpp

http://commits.kde.org/oxygen-gtk/0daca58264a453eb895cfd64a15e5e9ba93081ca
Comment 4 Ruslan Kabatsayev 2012-02-08 21:16:44 UTC
The above commit removes most of the warnings, namely those which are generated because of gtk.css *file*. There remains one error message, which originates from dynamically-generated css data.

@Hugo, I guess this is somewhere in oxygengtkcss.h, maybe in CSSOption(). I'm not sure in this, and you should know this code better, so I leave this one for you.
Comment 5 Hugo Pereira Da Costa 2012-02-13 09:52:18 UTC
Git commit 6d42cabbf6025fba4cff4ef9cea584574eda02ca by Hugo Pereira Da Costa.
Committed on 13/02/2012 at 10:51.
Pushed by hpereiradacosta into branch 'gtk3'.

added missing unit for "padding" option.

M  +1    -1    src/oxygenqtsettings.cpp

http://commits.kde.org/oxygen-gtk/6d42cabbf6025fba4cff4ef9cea584574eda02ca
Comment 6 Hugo Pereira Da Costa 2012-02-13 09:55:09 UTC
Ruslan ? Can you test that the above fixes the remaining warnings ? 
(I can't: back to gtk3.2)

If yes, please close

There is one remaining place where there might be warnings. 
It concerns the font sizes (namely things like: 
GtkMenuItem {
  font: Helvetica  8;
}

GtkToolbar {
  font: Helvetica  8;
}

But I'm not sure whether unit is needed (or even accepted) here. So please double check. 

Thanks in advance,

Hugo

PS: we'll need to backport this change, and possibly the ones on icons background to gtk3-1.0 (for which there should be a release in a couple of days).
Comment 7 Hugo Pereira Da Costa 2012-02-13 16:37:20 UTC
Git commit 046ef1c6f888eb69887aa8df75f2be69c3fff8d3 by Hugo Pereira Da Costa, on behalf of Ruslan Kabatsayev.
Committed on 08/02/2012 at 22:08.
Pushed by hpereiradacosta into branch 'gtk3-1.0'.

Add px units to all numbers in gtk.css

M  +50   -50   rc/gtk.css
M  +2    -2    src/oxygenqtsettings.cpp

http://commits.kde.org/oxygen-gtk/046ef1c6f888eb69887aa8df75f2be69c3fff8d3
Comment 8 Hugo Pereira Da Costa 2012-02-13 16:37:20 UTC
Git commit 50c181314d7b090f4b4f0c7e6e42fadb37f69f69 by Hugo Pereira Da Costa.
Committed on 13/02/2012 at 10:51.
Pushed by hpereiradacosta into branch 'gtk3-1.0'.

added missing unit for "padding" option.

M  +1    -1    src/oxygenqtsettings.cpp

http://commits.kde.org/oxygen-gtk/50c181314d7b090f4b4f0c7e6e42fadb37f69f69
Comment 9 Ruslan Kabatsayev 2012-02-13 17:04:03 UTC
Fixed.