Bug 291896

Summary: const mismatch in src/generator/state.*
Product: [Applications] ksudoku Reporter: tropikhajma <tropikhajma>
Component: generalAssignee: Ian Wadham <iandw.au>
Status: RESOLVED FIXED    
Severity: normal CC: kde-games-bugs
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Solaris   
Latest Commit: Version Fixed In: 1.0 (KDE SC 4.8.1)
Attachments: patch

Description tropikhajma 2012-01-18 19:35:31 UTC
Created attachment 67975 [details]
patch

Version:           unspecified (using Devel) 
OS:                Solaris

building kdegames 4.7.97 fails with the below error.
This is because guessNumber in State::State in .h is const int while the .cpp uses just int.
The Solaris Studio compiler is sensitive to this.

Reproducible: Didn't try

Steps to Reproduce:
try building kdegames

Actual Results:  
Linking CXX executable ksudoku
cd /opt/test2/packages/BUILD/kdegames-4.7.97/build-kdegames-4.7.97/ksudoku/src && /opt/kde4/bin/cmake -E cmake_link_script CMakeFiles/ksudoku.dir/link.txt --verbose=1
...
 file
Undefined			first referenced
 symbol  			    in file
State::State(QObject*,const QList<int>&,const int,const QVector<int>&,const QList<int>&,const QList<int>&) CMakeFiles/ksudoku.dir/generator/sudokuboard.o
ld: fatal: symbol referencing errors. No output written to ksudoku


Expected Results:  
builds ok

Solaris 11, Solaris Studio 12.3
Comment 1 Ian Wadham 2012-01-20 22:22:19 UTC
Thanks for the patch. I will commit it in a few days time, after the KDE SC 4.8 release, and will backport it into KDE SC 4.8.1, scheduled for 6 March.
Comment 2 Ian Wadham 2012-02-23 05:37:47 UTC
SVN commit 1281833 by ianw:

Related: bug 291896 Fix a const mismatch and allow compilation in Solaris Studio.

 M  +1 -1      state.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1281833
Comment 3 Ian Wadham 2012-02-23 05:46:38 UTC
SVN commit 1281834 by ianw:

Related: bug 291896 Backport to 4.8.1. Fix a const mismatch and allow compilation in Solaris Studio.

 M  +1 -1      state.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1281834