| Summary: | untranslatable unit "KiB/s" in jobwidget.cpp | ||
|---|---|---|---|
| Product: | [Plasma] plasma4 | Reporter: | Alexander Potashev <aspotashev> |
| Component: | notifications | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, cfeck, plasma-bugs |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | screenshot | ||
Maybe it is even possible to combine it with KLocale::formatByteSize() so that it shows "KB" instead of "KiB" on systems where it is configured to do so. SVN commit 1212155 by aacid: Use binaryUnitDialect, also make the strings translatable BUGS: 262232 M +15 -1 jobwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1212155 SVN commit 1212156 by aacid: backport r1212155 | aacid | 2011-01-05 22:51:16 +0000 (Wed, 05 Jan 2011) | 3 lines Use binaryUnitDialect, also make the strings translatable BUGS: 262232 M +15 -1 jobwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1212156 SVN commit 1212167 by aacid: I just realized it does not make sense to be smart about the unit to show if i don't change how calculations are done so revert the code that sets kib or kb Might make sense to open a different bug about compliance with the binary unit of user choice CCBUGS: 262232 M +0 -14 jobwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1212167 SVN commit 1212168 by aacid: I just realized it does not make sense to be smart about the unit to show if i don't change how calculations are done so revert the code that sets kib or kb Might make sense to open a different bug about compliance with the binary unit of user choice CCBUGS: 262232 M +0 -14 jobwidget.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1212168 |
Created attachment 55625 [details] screenshot Version: unspecified (using KDE 4.5.90) OS: Linux In kdebase/workspace/plasma/generic/applets/notifications/ui/jobwidget.cpp, line 65: m_plotter->setUnit("KiB/s"); Please, make this translatable. Reproducible: Always