Bug 260282

Summary:	More control restoring crashed windows/tabs session, on an individual basis
Product:	[Applications] konqueror	Reporter:	Luke-Jr <luke-jr+kdebugs>
Component:	session restore	Assignee:	Eduardo Robles Elvira <edulix>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	cfeck, chrislb, tchollingsworth
Priority:	NOR
Version:	4.4.5
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	http://commits.kde.org/kde-baseapps/a78c6a50dcb33028eb572bc260bdaca8f30a597a	Version Fixed In:	4.10

Description Luke-Jr 2010-12-16 16:20:21 UTC

Version:           4.4.5 (using KDE 4.4.5) 
OS:                Linux

The post-crash restore window should make it clear which pages are tabs in the same window. It should also allow the user to select specific windows/tabs to restore, in case the user does not wish to restore all at once (or discard some-- for example, if he knows which page crashed the browser and doesn't want to re-crash it). It would be a nice bonus if the prompt was also converted to a "default page" like Firefox 3.5 has, which can be simply navigated away from (without losing the saved pages) if the user doesn't wish to deal with it at the present moment (I often accidentally 'click' one of the buttons by beginning to type the URI I want).

Reproducible: Always

Comment 1 Christoph Feck 2012-09-19 21:24:28 UTC

*** Bug 216603 has been marked as a duplicate of this bug. ***

Comment 2 Dawit Alemayehu 2012-10-09 23:06:21 UTC

Git commit 0142a8ca11b00b5b24347b92700b7f6c5bdb3e75 by Dawit Alemayehu.
Committed on 19/09/2012 at 06:12.
Pushed by adawit into branch 'master'.

In the session restore dialog, allow the user to select which sessions should
be restored.
FIXED-IN: 4.10
REVIEW: 106503
GUI: new strings
DIGEST: Ability to select the session(s) to be restored in Konqueror.

M  +336  -56   konqueror/src/konqsessionmanager.cpp
M  +51   -0    konqueror/src/konqsessionmanager.h

http://commits.kde.org/kde-baseapps/0142a8ca11b00b5b24347b92700b7f6c5bdb3e75

Comment 3 T.C. Hollingsworth 2012-10-12 02:11:05 UTC

Git commit a78c6a50dcb33028eb572bc260bdaca8f30a597a by T.C. Hollingsworth, on behalf of Dawit Alemayehu.
Committed on 19/09/2012 at 06:12.
Pushed by hollingsworth into branch 'KDE/4.9'.

In the session restore dialog, allow the user to select which sessions should
be restored.
FIXED-IN: 4.10
REVIEW: 106503
GUI: new strings
DIGEST: Ability to select the session(s) to be restored in Konqueror.
(cherry picked from commit 0142a8ca11b00b5b24347b92700b7f6c5bdb3e75)

M  +336  -56   konqueror/src/konqsessionmanager.cpp
M  +51   -0    konqueror/src/konqsessionmanager.h

http://commits.kde.org/kde-baseapps/a78c6a50dcb33028eb572bc260bdaca8f30a597a

Comment 4 Christoph Feck 2012-10-12 10:04:59 UTC

Can you please check why this commit went to 4.9 branch? It adds new strings and a new feature, so it should not land in a stable branch.

Comment 5 Pino Toscano 2012-10-12 11:14:25 UTC

Git commit ac70302ee08d01793b3c22d288c19117c384e028 by Pino Toscano.
Committed on 12/10/2012 at 13:12.
Pushed by pino into branch 'KDE/4.9'.

Revert "In the session restore dialog, allow the user to select which sessions should"

Not meant for 4.9.

This reverts commit a78c6a50dcb33028eb572bc260bdaca8f30a597a.

M  +56   -336  konqueror/src/konqsessionmanager.cpp
M  +0    -51   konqueror/src/konqsessionmanager.h

http://commits.kde.org/kde-baseapps/ac70302ee08d01793b3c22d288c19117c384e028

Comment 6 Dawit Alemayehu 2012-10-16 22:42:03 UTC

*** Bug 207380 has been marked as a duplicate of this bug. ***