Summary: | Photo applet broken with other locales thant US/EN | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Cédric Bellegarde <web> |
Component: | Context View | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | budinero, lfranchi, scarpino, simon.esneault |
Priority: | NOR | ||
Version: | 2.2.2 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Fix for this bug |
Description
Cédric Bellegarde
2010-01-13 18:38:51 UTC
*** Bug 221951 has been marked as a duplicate of this bug. *** Created attachment 39854 [details]
Fix for this bug
Engine was sending translated data to applet looking for non translated...
I remove translation because i don't think we need to send translated data.
commit 7fc57a99e59da1ec225fcf5cbd6c8a40430e50c0 Author: Mark Kretschmann <kretschmann@kde.org> Date: Wed Jan 13 20:13:39 2010 +0100 Fix bug in Photos applet, didn't work with translated Amarok. Thanks to Bellegarde Cédric <gnumdk@gmail.com> for the patch. @Simon: Could you please verify and test this? BUG: 222566 diff --git a/ChangeLog b/ChangeLog index 0336a14..5897907 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,6 +2,7 @@ Amarok ChangeLog ================ (C) 2002-2010 the Amarok authors. + VERSION 2.2.3 FEATURES: * Non collection files with a cue sheet will now load their tracks as @@ -27,6 +28,8 @@ VERSION 2.2.3 files which incorrectly have the same MusicBrainz unique identifier. BUGFIXES: + * Fixed bug in Photos applet that made it break with translated versions + of Amarok. Patch by Bellegarde Cédric <gnumdk@gmail.com>. (BR 222566) * Lyrics applet: Fixed saving and restoring font styles. (BR 222277) * Lyrics applet: Fixed a bug where sometimes suggested URLs are not cleared when switching tracks. diff --git a/src/context/engines/photos/PhotosEngine.cpp b/src/context/engines/photos/PhotosEngine.cpp index 9c841f2..8aff13f 100644 --- a/src/context/engines/photos/PhotosEngine.cpp +++ b/src/context/engines/photos/PhotosEngine.cpp @@ -156,7 +156,7 @@ void PhotosEngine::update() // Show the information if( !m_artist.isEmpty() ) { - setData( "photos", "message", i18n( "Fetching" ) ); + setData( "photos", "message", "Fetching"); setData( "photos", "artist", m_artist ); } else |