Bug 215185

Summary:	Slim volume control acts strangely after startup
Product:	[Applications] amarok	Reporter:	Marcus Harrison <marcus>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	grosser.meister.morti, nhn, piotrek.juzwiak
Priority:	HI	Keywords:	release_blocker
Version:	2.3-GIT
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:

Description Marcus Harrison 2009-11-18 22:36:35 UTC

Version:           2.2.1 (using KDE 4.3.3)
OS:                Linux
Installed from:    Ubuntu Packages

With the slim toolbar selected, clicking the volume button drops-down the volume slider as expected. However, clicking on the slider immediately closes it, regardless of whether I click on the handle or somewhere on the slider. After clicking on the button a second time, the slider remains for me to change the volume until I click away, when it hides - as expected.

This only occurs on the first attempt to change the volume on the slim toolbar. Switching from slim to main to slim activates this bug, and restarting Amarok with the slim toolbar selected also activates this bug. Again, regardless of which of these I do, it only occurs on the first click - dropping down the slider again makes it behave as expected.

Comment 1 Marcus Harrison 2009-11-19 09:47:11 UTC

I've come to discover that, actually, what seems to be closing the volume controls is the appearance of the OSD: if the OSD is not shown when trying to change the controls, they close instantly. Clicking on them again when the OSD is shown lets you edit them as you expect.

Comment 2 Myriam Schweingruber 2009-11-19 11:02:48 UTC

*** Bug 215218 has been marked as a duplicate of this bug. ***

Comment 3 Myriam Schweingruber 2009-11-19 11:03:12 UTC

Setting to confirmed.

Comment 4 Mathias Panzenböck 2009-11-23 21:14:13 UTC

Actually this bug causes all menus to be closed when the OSD is displayed. Something that annoys a long time now, maybe even since 2.0.

Comment 5 Mark Kretschmann 2009-11-25 07:34:35 UTC

I could reproduce this issue, although the symptoms were slightly different here:

Clicking the slider made it move to 0%, or 100% (sometimes one, sometimes the other) very quickly. Going to investigate.

Comment 6 Mark Kretschmann 2009-11-25 11:06:44 UTC

I've just fixed this:

commit abcbe45b1dc743f8eb59459110016d3f7b6f6454
Author: Mark Kretschmann <kretschmann@kde.org>
Date:   Wed Nov 25 11:01:13 2009 +0100

    Fix recursion issue in Slim Toolbar's volume slider.

    What happened was that right after startup, when you changed the volume,
    the slider would go into a recursive loop and move to 100% (or 0%) quickly.
    Now the slider is using the Amarok::VolumeSlider class, which I have
    refactored and extended for this purpose.

    BUG: 215185

Comment 7 Nikolaj Hald Nielsen 2009-11-26 12:03:33 UTC

commit c306a091a25479f711f4597b075c9cad7185ab19
Author: Nikolaj Hald Nielsen <nhnFreespirit@gmail.com>
Date:   Thu Nov 26 11:58:03 2009 +0100

    Fix OSD stealing focus, resulting in any visible menus (or the volume slider in the slim toolbar) getting closed.
    CCBUG: 215185


I think this closes the last part of this bug!

Comment 8 Mathias Panzenböck 2009-11-26 14:38:30 UTC

Can confirm this as fixed.