Summary: | [Patch] magnatune url broken for non-english language | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Matevž Jekovec <matevz.jekovec> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, nhn |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | some fixes on magnatune |
Description
Matevž Jekovec
2009-10-28 00:13:27 UTC
to work it have to be : http://user:password@stream.magnatune.com/... whatever is the language ? Exactly! i think it should be better to not store the membership type in a translated way, using currentIndex could be better. i am trying some patches here. i will try to attach really soon for review this is when playing the files or adding it to favourite ? because i saw this behaviour when adding to favourite ( i have a patch for this one ) Created attachment 37927 [details]
some fixes on magnatune
In the code of magnatune there is a little pb. we compare m_config.membershipType() to the english string whereas this is translated on the config file. This patch fixes this issue.
Matevz, whoich Amarok version is this? Forgot to mention the patch in the title, sorry fixed in commit http://gitorious.org/amarok/amarok/commit/9070de03771104f4bac79f6673a877b1ae472778 please reopen if still valid on next amarok release |