Bug 212126 - [Patch] magnatune url broken for non-english language
Summary: [Patch] magnatune url broken for non-english language
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-28 00:13 UTC by Matevž Jekovec
Modified: 2009-11-22 12:37 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
some fixes on magnatune (2.42 KB, patch)
2009-10-28 02:21 UTC, Nicolas L.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matevž Jekovec 2009-10-28 00:13:27 UTC
Version:            (using KDE 4.3.2)
OS:                Linux
Installed from:    Ubuntu Packages

I registered myself at magnatune as a stream member and streaming using web browser works ok. But using it in amarok just skips the tracks, if I set the user/password in amarok settings.

I ran amarok in debug mode and noticed the magnatune stream request as:
http://user:password@tok.magnatune.com/...
where 'tok' is a Slovenian translation for 'stream'.

I set LANG=en_US, restarted amarok, readded the streams to the list and the playback went fine. Looks like the 'stream' term gets translated for the URL request, but it shouldn't.
Comment 1 Nicolas L. 2009-10-28 00:19:40 UTC
to work it have to be :

http://user:password@stream.magnatune.com/...  whatever is the language ?
Comment 2 Matevž Jekovec 2009-10-28 00:24:56 UTC
Exactly!
Comment 3 Nicolas L. 2009-10-28 00:45:01 UTC
i think it should be better to not store the membership  type in a translated way, using currentIndex could be better.

i am trying some patches here. i will try to attach really soon for review
Comment 4 Nicolas L. 2009-10-28 02:00:52 UTC
this is when playing the files or adding it to favourite ? because i saw this behaviour when adding to favourite ( i have a patch for this one )
Comment 5 Nicolas L. 2009-10-28 02:21:35 UTC
Created attachment 37927 [details]
some fixes on magnatune

In the code of magnatune there is a little pb. we compare m_config.membershipType() to the english string whereas this is translated on the config file. This patch fixes this issue.
Comment 6 Myriam Schweingruber 2009-10-28 20:58:42 UTC
Matevz, whoich Amarok version is this?
Comment 7 Myriam Schweingruber 2009-10-28 20:59:20 UTC
Forgot to mention the patch in the title, sorry
Comment 8 Nicolas L. 2009-11-22 12:37:04 UTC
fixed in commit http://gitorious.org/amarok/amarok/commit/9070de03771104f4bac79f6673a877b1ae472778


please reopen if still valid on next amarok release