Summary: | Crash when typing Return two times after a term in the search box | ||
---|---|---|---|
Product: | [Applications] marble | Reporter: | gerlos <gerlosgm> |
Component: | general | Assignee: | marble-bugs |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | nienhueser |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | 0.8 (KDE 4.3) | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | marble-bug210013.diff |
Description
gerlos
2009-10-09 20:23:06 UTC
Confirmed for current trunk [Version 0.9 SVN Using KDE 4.3.74 (KDE 4.3.74 (KDE 4.4 >= 20091102))] Not always happening here, but I was able to reproduce it twice with different keywords. There's another, related bug: Hitting enter n times while the search is running will execute the search n times, and each result will come in n times as well. Created attachment 38135 [details] marble-bug210013.diff This patch should fix both issues. Is there any case I'm not seeing where a consecutive search for the same term should be executed multiple times? If yes, double searches should be prevented in the MarbleControlBox instead. If not, I'll check in the patch. SVN commit 1048810 by nienhueser: Do not search for the same term more than once in a row. Avoids duplicated result entries and crashes. CCBUG: 210013 M +3 -0 MarbleRunnerManager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1048810 SVN commit 1049435 by nienhueser: Do not search for the same term more than once in a row. Avoids duplicated result entries and crashes. Backport of commit 1048810 BUG: 210013 Please follow up in https://bugs.kde.org/show_bug.cgi?id=206534 for crashes related to multiple search queries running at the same time. M +9 -7 MarbleRunnerManager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1049435 |