Bug 205729

Summary:	KCM reports incorrect number of arguments for dbus functions
Product:	[Applications] amarok	Reporter:	Ben Morris <bugs>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	edward.hades, fscheffold, mzanetti
Priority:	NOR
Version:	2.1.1
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:

Description Ben Morris 2009-08-30 22:05:13 UTC

Version:            (using KDE 4.3.0)
OS:                Linux
Installed from:    Gentoo Packages

When trying to set up a "Use D-Bus" action to change Amarok's volume, I noticed that it referred to the relevant function as "void VolumeUp()" (instead of "void VolumeUp(int)"), and did not offer me a chance to configure its argument (the percent by which volume should be increased).

Here is what the function really looks like:

$ qdbus org.mpris.amarok /Player
[snip]
method void org.freedesktop.MediaPlayer.VolumeUp(int)
[snip]

Unsurprisingly, the action does not work. I am able to control other Amarok dbus functions using my remote.

Versions:
$ irkick -v
Qt: 4.5.1
KDE: 4.3.00 (KDE 4.3.0)
IRKick: 4.3.0

$ amarok -v
Qt: 4.5.1
KDE: 4.3.00 (KDE 4.3.0)
Amarok: 2.1.1

Comment 1 Michael Zanetti 2009-08-31 21:11:37 UTC

While investigating I noticed that this is because of a typo in amarok's dbus interface.

in src/dbus/org.freedesktop.mediaplayer.xml

the functions VolumeUp(), VolumeDown() and LoadThemeFile() have a property called "drection" instead of "direction" (Note the missing 'i').


I still wonder why qdbus parses this correctly...

Comment 2 Edward Hades 2009-09-02 18:29:55 UTC

Fixed, thank you!

commit d320ce65fbaff06c5a2568c0e9d741a689d06857
Author: Edward Hades <edward.hades@gmail.com>
Date:   Wed Sep 2 20:27:07 2009 +0400

    Fixed typo in d-bus manifest.

    BUG: 205729

 src/dbus/org.freedesktop.MediaPlayer.player.xml |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Comment 3 Ben Morris 2009-09-16 15:54:15 UTC

Works for me in Amarok 2.1.85. Thanks guys.