Bug 205729 - KCM reports incorrect number of arguments for dbus functions
Summary: KCM reports incorrect number of arguments for dbus functions
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.1.1
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-30 22:05 UTC by Ben Morris
Modified: 2009-09-16 15:54 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Morris 2009-08-30 22:05:13 UTC
Version:            (using KDE 4.3.0)
OS:                Linux
Installed from:    Gentoo Packages

When trying to set up a "Use D-Bus" action to change Amarok's volume, I noticed that it referred to the relevant function as "void VolumeUp()" (instead of "void VolumeUp(int)"), and did not offer me a chance to configure its argument (the percent by which volume should be increased).

Here is what the function really looks like:

$ qdbus org.mpris.amarok /Player
[snip]
method void org.freedesktop.MediaPlayer.VolumeUp(int)
[snip]

Unsurprisingly, the action does not work. I am able to control other Amarok dbus functions using my remote.

Versions:
$ irkick -v
Qt: 4.5.1
KDE: 4.3.00 (KDE 4.3.0)
IRKick: 4.3.0

$ amarok -v
Qt: 4.5.1
KDE: 4.3.00 (KDE 4.3.0)
Amarok: 2.1.1
Comment 1 Michael Zanetti 2009-08-31 21:11:37 UTC
While investigating I noticed that this is because of a typo in amarok's dbus interface.

in src/dbus/org.freedesktop.mediaplayer.xml

the functions VolumeUp(), VolumeDown() and LoadThemeFile() have a property called "drection" instead of "direction" (Note the missing 'i').


I still wonder why qdbus parses this correctly...
Comment 2 Edward Hades 2009-09-02 18:29:55 UTC
Fixed, thank you!

commit d320ce65fbaff06c5a2568c0e9d741a689d06857
Author: Edward Hades <edward.hades@gmail.com>
Date:   Wed Sep 2 20:27:07 2009 +0400

    Fixed typo in d-bus manifest.

    BUG: 205729

 src/dbus/org.freedesktop.MediaPlayer.player.xml |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Comment 3 Ben Morris 2009-09-16 15:54:15 UTC
Works for me in Amarok 2.1.85. Thanks guys.