Summary: | [PATCH] Add support for AIFF in Amarok since every iPod supports it | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Rashad Tatum <tatum.rashad> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aikawarazuni |
Priority: | NOR | ||
Version: | 2.2-SVN | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Adds support for AIFF. |
Description
Rashad Tatum
2009-07-20 02:48:15 UTC
Created attachment 35469 [details]
Adds support for AIFF.
Copying the patch inline: Index: src/amarok/src/collection/ipodcollection/handler/IpodHandler.cpp =================================================================== --- src/amarok/src/collection/ipodcollection/handler/IpodHandler.cpp (revision 999501) +++ src/amarok/src/collection/ipodcollection/handler/IpodHandler.cpp (working copy) @@ -902,6 +902,7 @@ DEBUG_BLOCK // findPathToCopy( srcTrack ); KUrl srcurl = KUrl::fromPath( srcTrack->playableUrl().path() ); + debug() << "Copying " << srcTrack << " to " << destTrack; m_trackscopying[ srcurl ] = srcTrack; return kioCopyTrack( srcurl, m_trackdesturl[ srcTrack ] ); } @@ -1478,6 +1479,10 @@ { m_itdbtrackhash[ track ]->filetype = g_strdup( "wav" ); } + else if( type=="aiff" ) + { + m_itdbtrackhash[ track ]->filetype = g_strdup( "aiff" ); + } else if(type=="mp3" || type=="mpeg") { m_itdbtrackhash[ track ]->filetype = g_strdup( "mpeg" ); @@ -1754,8 +1759,9 @@ { QStringList formats; - formats << "mp3" << "aac" << "mp4" << "m4a"; + formats << "mp3" << "aac" << "mp4" << "m4a" << "aiff"; + return formats; } Nice, thanks for the patch, will try tonight after work if I can find an aiff lying around. If there's other formats left, don't feel shy about adding them in either. Alejandro, any news about this patch? Implemented locally, I'll push to git-mainline soon. |