Summary: | [PATCH] OSD should set window type hint | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Danny Baumann <dannybaumann> |
Component: | Notifications | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 2.0.2 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Fix |
Description
Danny Baumann
2009-05-29 09:59:58 UTC
Created attachment 34095 [details]
Fix
(Trivial) patch which sets the notification type hint in the X11 environment.
Danny, I've just tried your patch, but I can't see any difference from an unpatched OSD (running KWin). Can you explain in what situations/environments the patch is needed? (In reply to comment #2) > Danny, I've just tried your patch, but I can't see any difference from an > unpatched OSD (running KWin). > > Can you explain in what situations/environments the patch is needed? I use compiz and have set different animation rules for 'normal' windows and 'notification' windows. Normal windows have a fly-in animation, while notification windows open with some unintrusive fold animation. It's much nicer when the OSD doesn't fly in anymore ;) (NB: KWin has grown pretty good compositing abilities lately, but its window animations badly lack configurability) One might argue that this is an irrelevant use case, but the OSD _is_ a notification window after all, so there's not really a reason to not set the window type accordingly, especially as other amarok windows (e.g. equalizer setup) set it as well. Ok, thanks for the explanation. Makes sense to me. Mark, is this patch already implemented? Yes, the code is in 2.2-GIT. |