Bug 194517 - [PATCH] OSD should set window type hint
Summary: [PATCH] OSD should set window type hint
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Notifications (show other bugs)
Version: 2.0.2
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-29 09:59 UTC by Danny Baumann
Modified: 2009-12-09 11:29 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Fix (590 bytes, patch)
2009-05-29 10:00 UTC, Danny Baumann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Danny Baumann 2009-05-29 09:59:58 UTC
Version:           2.0.2 (using KDE 4.2.3)
OS:                Linux
Installed from:    Fedora RPMs

The OSD should indicate its window type (notification) on platforms that support it, so that window and (especially) compositing managers can handle it appropriately.

I will attach a patch which implements that.
Comment 1 Danny Baumann 2009-05-29 10:00:57 UTC
Created attachment 34095 [details]
Fix

(Trivial) patch which sets the notification type hint in the X11 environment.
Comment 2 Mark Kretschmann 2009-05-29 10:19:14 UTC
Danny, I've just tried your patch, but I can't see any difference from an unpatched OSD (running KWin).

Can you explain in what situations/environments the patch is needed?
Comment 3 Danny Baumann 2009-05-29 10:33:22 UTC
(In reply to comment #2)
> Danny, I've just tried your patch, but I can't see any difference from an
> unpatched OSD (running KWin).
> 
> Can you explain in what situations/environments the patch is needed?

I use compiz and have set different animation rules for 'normal' windows and 'notification' windows. Normal windows have a fly-in animation, while notification windows open with some unintrusive fold animation. It's much nicer when the OSD doesn't fly in anymore ;)
(NB: KWin has grown pretty good compositing abilities lately, but its window animations badly lack configurability)

One might argue that this is an irrelevant use case, but the OSD _is_ a notification window after all, so there's not really a reason to not set the window type accordingly, especially as other amarok windows (e.g. equalizer setup) set it as well.
Comment 4 Mark Kretschmann 2009-05-29 10:44:39 UTC
Ok, thanks for the explanation. Makes sense to me.
Comment 5 Myriam Schweingruber 2009-08-02 16:56:02 UTC
Mark, is this patch already implemented?
Comment 6 Mark Kretschmann 2009-08-11 18:37:19 UTC
Yes, the code is in 2.2-GIT.