Summary: | Playlist showing wrong song as being played | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Linus Östberg <kdebugs> |
Component: | Playlist | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nhn, sven.burmeister, sven |
Priority: | HI | ||
Version: | 2.0.1 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
Screenshot
Patch to prevent the wrong song to be displayed as current in the playlist |
Description
Linus Östberg
2009-01-26 02:56:57 UTC
Created attachment 30616 [details]
Screenshot
Just added a screenshot showing the bug. As can be seen, the current playing song is not the same as the one shown in the playlist.
This is still the case with Rev: 933361 I'm unable to reproduce this with r938536. Reporter: can you? Btw: good music taste in the screenshot. ;-) Rev: 938525 and still reproduceable. Play a song and while playing add another one via drag and drop above the currently playing song. Created attachment 32248 [details]
Patch to prevent the wrong song to be displayed as current in the playlist
Here's a patch fixing the problem, by incrementing the m_activeRow when files are add above the current playing one in the playlist.
SVN commit 941584 by vrouet: Bugfixes : 1) Prevent playlist from showing a wrong playing song after adding tracks above it. CCBUG: 181947 2) Show the current playing song when resuming playback of a track not in the collection. CCBUG: 173912 M +4 -0 ChangeLog M +4 -0 src/App.cpp M +6 -1 src/playlist/PlaylistActions.cpp M +8 -0 src/playlist/PlaylistModel.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=941584 Closing. Thanks Valentin :) SVN commit 953309 by vrouet: My last commit about adding tracks above the current one in the playlist didn't solve the problem completely, now it's fixed. BUG: 181947 M +3 -3 PlaylistModel.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=953309 |