Bug 181947 - Playlist showing wrong song as being played
Summary: Playlist showing wrong song as being played
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.0.1
Platform: Ubuntu Linux
: HI normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-26 02:56 UTC by Linus Östberg
Modified: 2009-12-09 11:29 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot (176.11 KB, image/png)
2009-01-26 02:58 UTC, Linus Östberg
Details
Patch to prevent the wrong song to be displayed as current in the playlist (2.43 KB, patch)
2009-03-19 03:59 UTC, Valentin Rouet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Linus Östberg 2009-01-26 02:56:57 UTC
Version:           2.0.1 (using KDE 4.1.4)
OS:                Linux
Installed from:    Ubuntu Packages

If the playlist is updated while playing a song, the wrong song will be shon as being played if the songs are added above the current playing song.

To reproduce: start playing a song, then add another song just above the current playing song.
Comment 1 Linus Östberg 2009-01-26 02:58:48 UTC
Created attachment 30616 [details]
Screenshot

Just added a screenshot showing the bug. As can be seen, the current playing song is not the same as the one shown in the playlist.
Comment 2 S. Burmeister 2009-03-01 00:30:00 UTC
This is still the case with Rev: 933361
Comment 3 Sven Krohlas 2009-03-12 10:09:25 UTC
I'm unable to reproduce this with r938536.

Reporter: can you?

Btw: good music taste in the screenshot. ;-)
Comment 4 S. Burmeister 2009-03-12 10:53:39 UTC
Rev: 938525 and still reproduceable. Play a song and while playing add another one via drag and drop above the currently playing song.
Comment 5 Valentin Rouet 2009-03-19 03:59:16 UTC
Created attachment 32248 [details]
Patch to prevent the wrong song to be displayed as current in the playlist

Here's a patch fixing the problem, by incrementing the m_activeRow when files are add above the current playing one in the playlist.
Comment 6 Valentin Rouet 2009-03-20 02:00:50 UTC
SVN commit 941584 by vrouet:

Bugfixes :
1) Prevent playlist from showing a wrong playing song after adding tracks above it.
CCBUG: 181947

2) Show the current playing song when resuming playback of a track not in the collection.
CCBUG: 173912

 M  +4 -0      ChangeLog  
 M  +4 -0      src/App.cpp  
 M  +6 -1      src/playlist/PlaylistActions.cpp  
 M  +8 -0      src/playlist/PlaylistModel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=941584
Comment 7 Lydia Pintscher 2009-03-20 09:53:25 UTC
Closing. Thanks Valentin :)
Comment 8 Valentin Rouet 2009-04-13 19:47:59 UTC
SVN commit 953309 by vrouet:

My last commit about adding tracks above the current one in the playlist didn't solve the problem completely, now it's fixed.
BUG: 181947

 M  +3 -3      PlaylistModel.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=953309