Summary: | Export menu items disabled by default | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Michael Ploujnikov <ploujj> |
Component: | Usability-Menus | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | caulier.gilles, marcel.wiesweg |
Priority: | NOR | ||
Version: | 0.10.0 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 0.10.0 | |
Attachments: |
all Export menu items are disabled
my digikamrc file |
Description
Michael Ploujnikov
2009-01-14 02:12:40 UTC
Created attachment 30230 [details]
all Export menu items are disabled
This is what I see in every tab except for the "Albums" tab right after loading digikam.
Created attachment 30231 [details]
my digikamrc file
After more experimentation the "Export" menu seems to get enabled and disabled randomly but reproducibly as I switch between different tabs. For example: * with the attached digikamrc, digikam starts in the Timeline tab. The "Export" menu is disabled. * I go to the "Searches" tab and the "Export" menu is still disabled. * I go to the "Calendar" tab and the "Export" menu stays disabled. * I go to the "Tags" tab and the "Export" menu becomes enabled. * I go to the "Calendar" tab and the "Export" menu stays enabled. * I go to the "Searches" tab and the "Export" menu stays enabled. * I go to the "Timeline" tab and the "Export" menu becomes disabled. * I go to the "Calendar" tab and the "Export" menu stays disabled. * I go to the "Albums" tab and the "Export" menu becomes enabled. * I go to the "Timeline" tab and the "Export" menu becomes disabled. * I go to the "Tags" tab and the "Export" menu becomes enabled. Gilles, you no better than me the kipi plugins (to test most of them I need login data etc.): They work on the currently selected pictures, don't they? Or do they access the current album? It seems HTML export uses its own album select widget, and not the current album, some others use the current selection. We currently enable/disable the export actions depending on if there is a physical album or a tag album active; I think this is wrong, they should be enabled if there is any album active? Or if there is a non-empty album? Marcel, Following code from : http://lxr.kde.org/source/extragear/graphics/digikam/digikam/digikamapp.cpp#1167 Marcel, Following code from : http://lxr.kde.org/source/extragear/graphics/digikam/digikam/digikamapp.cpp#1167 and http://lxr.kde.org/source/extragear/graphics/digikam/digikam/digikamapp.cpp#1220 I think that all rules to enable or disable plugins action depending of current album selection is wrong. This must be done directly in plugins code, not in digiKam. Also, flickrExport for example is a modaless dialog. you can go back to digiKam make a new selection and D&D images to plugin. There is no reason to not be able to use date album content with flickr export. Currently it's the case. Also the logic used in these method is not clear... Gilles SVN commit 910844 by cgilles: digiKam from trunk: do not limit export tools to use physical albums/tags contents. BUG: 180609 M +3 -22 digikamapp.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=910844 SVN commit 911590 by cgilles: backport commit #910844 from trunk CCBUG: 180609 M +2 -33 digikamapp.cpp M +1 -1 digikamapp.h WebSVN link: http://websvn.kde.org/?view=rev&revision=911590 |