Bug 174769

Summary:	Writing of settings to kwinrc should be postponed until user confirms desktop effects settings
Product:	[Plasma] kwin	Reporter:	Erlend Hamberg <ehamberg>
Component:	general	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	acilia
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Unspecified
Latest Commit:		Version Fixed In:

Description Erlend Hamberg 2008-11-10 10:51:50 UTC

Version:            (using Devel)
Installed from:    Compiled sources

When doing some testing of desktop effects setting with Intel drivers i chose "Fallback" as OpenGL mode. This resulted in an X.org crash before I got the "confirm new settings" dialogue from kwin.

When trying to log in again X.org crashes again because the settings I didn't cofirm were still being used.
Opening kwinrc confirmed this.
The solution was to manually edit kwinrc, specifying the old value for OpenGL mode.

I suggest to postpone writing the settings to kwinrc until after the user accepts the new settings in the confirmation dialogue.

Comment 1 David Nadlinger 2008-11-10 14:35:08 UTC

To me, this seems like a reasonable enhancement. Any other comments?

If not, I'll probably give it a shot in the next few days...

Comment 2 lucas 2008-11-19 09:34:48 UTC

*** Bug 162205 has been marked as a duplicate of this bug. ***

Comment 3 lucas 2008-11-29 17:53:30 UTC

SVN commit 888659 by dnadlinger:

When modifying the compositing settings, save a backup of kwinrc to another file to be able to revert if the X server crashes while testing the new config.
Also fixed a little bug in kcmkwincompositing (dropdowns on the general tab were not updated correctly) and cleaned up the code a bit (removed a few unneeded function calls and stale connects).

See the conversation on the mailing list ("Patch for bug 174769", http://lists.kde.org/?l=kwin&m=122696916611602) for further information.

BUG 174769



 M  +218 -157  kcmkwin/kwincompositing/main.cpp
 M  +21 -12    kcmkwin/kwincompositing/main.h
 M  +77 -41    options.cpp
 M  +7 -1      options.h
 M  +2 -5      org.kde.KWin.xml
 M  +7 -19     workspace.cpp
 M  +2 -3      workspace.h

Comment 4 David Nadlinger 2008-12-08 16:06:03 UTC

Due to an elusive bug we were unable to fix (bug 177178), the changes that fixed this issue were reverted.

The KWin configuration system will probably undergo a complete rewrite for KDE 4.3; we will also deal with this issue then.

Comment 5 Thomas Lübking 2012-03-14 21:46:23 UTC

There's a security check and we get bug reports and forum posts that kde dared to start without shadows just because X crashed when activating them ;-)