Bug 172715

Summary:	JJ: Make wikipedia/lyrics engine MetaObserver
Product:	[Applications] amarok	Reporter:	Nikolaj Hald Nielsen <nhn>
Component:	Context View	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	suppandi
Priority:	NOR	Keywords:	junior-jobs
Version:	2.0-SVN
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:		Version Fixed In:

Description Nikolaj Hald Nielsen 2008-10-13 13:54:21 UTC

Currently the Wikipedia applet does not update when the metadata of a radio station stream changes. This could be fixed by simply making the WikipediaEngine a MetaObserver. An example of how this works can be seen in the CurrentEngine

Comment 1 Mark Kretschmann 2008-10-13 14:17:43 UTC

The same is true for the lyrics engine, I think.

Comment 2 Lydia Pintscher 2008-10-17 12:17:11 UTC

*** Bug 171714 has been marked as a duplicate of this bug. ***

Comment 3 Mark Kretschmann 2008-11-06 19:40:26 UTC

SVN commit 880877 by markey:

The wikipedia applet now updates on Shoutcast streams. Made it subclass Meta:Observer.

CCBUG: 172715


 M  +1 -0      ChangeLog  
 M  +12 -0     src/context/engines/wikipedia/WikipediaEngine.cpp  
 M  +8 -1      src/context/engines/wikipedia/WikipediaEngine.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=880877

Comment 4 Mark Kretschmann 2008-11-06 20:46:21 UTC

SVN commit 880895 by markey:

Made the LyricsEngine a Meta::Observer, so that it updates with streams too.

BUG: 172715


 M  +1 -1      ChangeLog  
 M  +13 -1     src/context/engines/lyrics/LyricsEngine.cpp  
 M  +10 -3     src/context/engines/lyrics/LyricsEngine.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=880895