Bug 172715 - JJ: Make wikipedia/lyrics engine MetaObserver
Summary: JJ: Make wikipedia/lyrics engine MetaObserver
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Context View (show other bugs)
Version: 2.0-SVN
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords: junior-jobs
: 171714 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-10-13 13:54 UTC by Nikolaj Hald Nielsen
Modified: 2008-11-06 20:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolaj Hald Nielsen 2008-10-13 13:54:21 UTC 
Currently the Wikipedia applet does not update when the metadata of a radio station stream changes. This could be fixed by simply making the WikipediaEngine a MetaObserver. An example of how this works can be seen in the CurrentEngine
Comment 1 Mark Kretschmann 2008-10-13 14:17:43 UTC 
The same is true for the lyrics engine, I think.
Comment 2 Lydia Pintscher 2008-10-17 12:17:11 UTC 
*** Bug 171714 has been marked as a duplicate of this bug. ***
Comment 3 Mark Kretschmann 2008-11-06 19:40:26 UTC 
SVN commit 880877 by markey:

The wikipedia applet now updates on Shoutcast streams. Made it subclass Meta:Observer.

CCBUG: 172715


 M  +1 -0      ChangeLog  
 M  +12 -0     src/context/engines/wikipedia/WikipediaEngine.cpp  
 M  +8 -1      src/context/engines/wikipedia/WikipediaEngine.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=880877
Comment 4 Mark Kretschmann 2008-11-06 20:46:21 UTC 
SVN commit 880895 by markey:

Made the LyricsEngine a Meta::Observer, so that it updates with streams too.

BUG: 172715


 M  +1 -1      ChangeLog  
 M  +13 -1     src/context/engines/lyrics/LyricsEngine.cpp  
 M  +10 -3     src/context/engines/lyrics/LyricsEngine.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=880895