Bug 163605

Summary:	"article" menu should be disabled if no article is selected
Product:	[Applications] akregator	Reporter:	FiNeX <finex>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	haakon
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Patch to disable article-related actions when no article is shown Patch to disable article-related actions when no article is shown

Description FiNeX 2008-06-09 14:08:10 UTC

Version:           Revision 818680 (using Devel)
Installed from:    Compiled sources
OS:                Linux

When you start akregator or choose a folder/feed, no articles are selected, so the "Article" menu which contains action related to a selected article, should be disabled.

Comment 1 FiNeX 2008-12-26 21:05:50 UTC

This bug is still valid on trunk and 4.2 beta2.

Comment 2 Haakon Nilsen 2009-03-19 21:37:14 UTC

Created attachment 32268 [details]
Patch to disable article-related actions when no article is shown

The attach patch implements this (works on trunk).

When the about page is shown and a user triggers any article-related action, Akregator crashes. The patch also fixes this by disabling the actions in this situation.

Comment 3 Haakon Nilsen 2009-03-20 16:25:47 UTC

Created attachment 32289 [details]
Patch to disable article-related actions when no article is shown

Updated patch to respect the code style of the project.

Comment 4 Haakon Nilsen 2009-03-21 01:19:43 UTC

Confirmed that patch works both when running as stand-alone and as a part in Kontact.

Comment 5 Frank Osterfeld 2009-03-24 21:59:31 UTC

SVN commit 944014 by osterfeld:

disable article actions if no article is selected
Based on a patch by Haakon Nilsen
BUG:163605


 _M            . (directory)  
 M  +2 -0      akregator/src/actionmanager.h  
 M  +16 -0     akregator/src/actionmanagerimpl.cpp  
 M  +7 -5      akregator/src/actionmanagerimpl.h  
 M  +10 -0     akregator/src/articleviewer.cpp  
 M  +2 -0      akregator/src/articleviewer.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=944014