Summary: | Journal date grid has dates with Calendar entries bold. | ||
---|---|---|---|
Product: | [Applications] korganizer | Reporter: | Dotan Cohen <kde-2011.08> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | lemma, smartins |
Priority: | NOR | Keywords: | triaged |
Version: | SVN trunk (KDE 4) | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Dotan Cohen
2008-01-02 09:32:56 UTC
Still reproducible in trunk r865573. I don't see a way to figure out which days have journal entries. Right, the day matrix only emboldens days which have events, I plan to fix this, but not too soon. SVN commit 942964 by smartins: Added 2 options to config (Views->Date Navigator) so users can choose whether to highlight to-dos and journals in Todo and Journal View. I was changing kodaymatrix so it updates it's highlight settings when config changes, but that's too problematic, it doesn't know which view is selected. So I created a BaseView::getHighlightMode() that's responsible for knowing what the highlight logic should be, this way we don't have the logic spread in date navigator and all over koviewmanager. e.g: If you want to highlight both to-dos and events when in Todo View, just go to TodoView::getHighlightMode() and change it, no need to change code in date navigator. DO-NOT-BACKPORT: BUG: 154961 M +20 -1 calendarview.cpp M +7 -1 calendarview.h M +8 -0 interfaces/korganizer/baseview.cpp M +16 -0 interfaces/korganizer/baseview.h M +40 -10 kodaymatrix.cpp M +4 -1 kodaymatrix.h M +2 -0 koprefsdialog.cpp M +14 -2 korganizer.kcfg M +1 -11 koviewmanager.cpp M +10 -0 views/journalview/kojournalview.cpp M +5 -0 views/journalview/kojournalview.h M +8 -0 views/todoview/kotodoview.cpp M +5 -0 views/todoview/kotodoview.h WebSVN link: http://websvn.kde.org/?view=rev&revision=942964 |