Summary: | connection preferences layout on network settings | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | FiNeX <finex> |
Component: | general | Assignee: | Simon Edwards <simon> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
network settings bug
Patch for grouping objects annma's patch! |
Description
FiNeX
2007-11-14 20:17:12 UTC
Created attachment 22059 [details]
network settings bug
SVN commit 736860 by winterz: Almost fix the bug "connection preferences layout on network settings" The configuration dialog is now readable, but the QGroupBox titles are sliced in-half and I don't know why. CCBUG: 152317 M +20 -17 netpref.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=736860 You have a QGroupBox titled "Timeout Values" but it is empty. You should add the sliders into the group box, not under. sb_socketRead, sb_proxyConnect, sb_serverConnect and sb_serverResponse should be inside the QGroupBox. You should do that not for resolving the half cutted label, but for a logical reason: a QGroup box is a container, is not only a title with fancy graphics. Meanwhile, doing so, you resolve the problem on the titles. Anyway I'll open a new bug for the incorrect display of an empty QGroupBox. I've just done a small patch. I'll upload it now. Created attachment 22070 [details]
Patch for grouping objects
This patch will correct the form. Apply to the revision 737008.
hey, I also corrected the form!!! patch attached, seems almost the same than FiNeX: set a Vertical Layout in each groupbox. btw, why doesn't have the netpref.cpp and netpref.h any license and copyright holder? Created attachment 22088 [details]
annma's patch!
SVN commit 737479 by annma: fix layout by adding a vertical layout in each groupbox BUG=152317 M +8 -6 netpref.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=737479 |