Bug 152317 - connection preferences layout on network settings
Summary: connection preferences layout on network settings
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Simon Edwards
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-14 20:17 UTC by FiNeX
Modified: 2007-11-16 11:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
network settings bug (33.76 KB, image/jpeg)
2007-11-14 20:17 UTC, FiNeX
Details
Patch for grouping objects (3.09 KB, patch)
2007-11-15 10:53 UTC, FiNeX
Details
annma's patch! (2.95 KB, text/plain)
2007-11-16 11:09 UTC, Anne-Marie Mahfouf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description FiNeX 2007-11-14 20:17:12 UTC
Version:           SVN revision 736690 (using KDE Devel)
Installed from:    Compiled sources

The widget layout in the "connection preferences" tab are all shuffled.

systemsettings -> network settings -> * connection preferences *

I'll attach a screenshot :-)
Comment 1 FiNeX 2007-11-14 20:17:39 UTC
Created attachment 22059 [details]
network settings bug
Comment 2 Allen Winter 2007-11-15 02:05:53 UTC
SVN commit 736860 by winterz:

Almost fix the bug "connection preferences layout on network settings"
The configuration dialog is now readable, but the QGroupBox titles are sliced in-half
and I don't know why.

CCBUG: 152317


 M  +20 -17    netpref.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=736860
Comment 3 FiNeX 2007-11-15 10:51:19 UTC
You have a QGroupBox titled "Timeout Values" but it is empty. You should add the sliders into the group box, not under.
sb_socketRead, sb_proxyConnect, sb_serverConnect and sb_serverResponse should be inside the QGroupBox. You should do that not for resolving the half cutted label, but for a logical reason: a QGroup box is a container, is not only a title with fancy graphics.
Meanwhile, doing so, you resolve the problem on the titles.
Anyway I'll open a new bug for the incorrect display of an empty QGroupBox.
I've just done a small patch. I'll upload it now.
Comment 4 FiNeX 2007-11-15 10:53:23 UTC
Created attachment 22070 [details]
Patch for grouping objects

This patch will correct the form. Apply to the revision 737008.
Comment 5 Anne-Marie Mahfouf 2007-11-16 11:08:26 UTC
hey, I also corrected the form!!! patch attached, seems almost the same than FiNeX: set a Vertical Layout in each groupbox.

btw, why doesn't have the netpref.cpp and netpref.h any license and copyright holder?
Comment 6 Anne-Marie Mahfouf 2007-11-16 11:09:53 UTC
Created attachment 22088 [details]
annma's patch!
Comment 7 Anne-Marie Mahfouf 2007-11-16 11:43:41 UTC
SVN commit 737479 by annma:

fix layout by adding a vertical layout in each groupbox
BUG=152317


 M  +8 -6      netpref.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=737479