Bug 147689

Summary:	cameras.xml file not closed
Product:	[Applications] digikam	Reporter:	M. Asselstine <asselsm>
Component:	Setup-Cameras	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian stable
OS:	Linux
Latest Commit:		Version Fixed In:	7.6.0
Attachments:	possible fix

Description M. Asselstine 2007-07-09 04:46:25 UTC

Version:           cvs HEAD (using KDE KDE 3.5.5)
Installed from:    Debian stable Packages
OS:                Linux

In examining the digikam code base in subversion I notice that CameraList::load() does not close the file opened in the function. This will of course not necessarily crash the application but is not generally a good idea and I suspect that it was just missed.

Comment 1 M. Asselstine 2007-07-09 04:50:13 UTC

Created attachment 21094 [details]
possible fix

Comment 2 caulier.gilles 2007-07-10 22:35:09 UTC

Asselstine,

No need to call close() method, it closed when QFile instance is destroyed. Look here :

http://doc.trolltech.com/3.3/qfile#~QFile

So it's done automaticly by Qt.

Gilles Caulier