Summary: | "configure podcasts" menu entry has no effect if no podcasts defined | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | richlv |
Component: | Podcast | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 1.4.7 | ||
Target Milestone: | --- | ||
Platform: | Slackware | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
richlv
2007-06-07 18:16:17 UTC
Same here with me! I don't understand the issue. If you have no podcasts, why are you complaining if you can't configure them? Maybe the configure option should disappear then (gray out)? SVN commit 707393 by mitchell: Don't enable "Configure Podcasts" at the top level Podcasts folder if there's nothing underneath. It'll still be a do-nothing op if only subfolders are underneath, but fixing it further is too much needless hacking on stable branch. BUG: 146504 M +2 -0 ChangeLog M +2 -0 src/playlistbrowseritem.cpp --- branches/stable/extragear/multimedia/amarok/ChangeLog #707392:707393 @@ -5,6 +5,8 @@ VERSION 1.4.8 BUGFIXES: + * Don't enable "Configure Podcasts" at the top-level Podcasts folder if + there is nothing beneath it. (BR 146504) * Generic Media Device could copy some non-ASCII filenames to turn to gibberish. Thanks to David Smith <davidsmith@acm.org> for the fix. * Fixed possible GUI freeze when Amarok was showing the dialog for --- branches/stable/extragear/multimedia/amarok/src/playlistbrowseritem.cpp #707392:707393 @@ -438,6 +438,8 @@ menu.insertItem( SmallIconSet( Amarok::icon( "refresh" ) ), i18n("Refresh All Podcasts"), REFRESH ); menu.insertSeparator(); menu.insertItem( SmallIconSet( Amarok::icon( "configure" ) ), i18n( "&Configure Podcasts..." ), CONFIG ); + if( parentCat->childCount() == 0 ) + menu.setItemEnabled( CONFIG, false ); if( parentCat == this ) menu.insertItem( SmallIconSet( Amarok::icon( "configure" ) ), i18n("Scan Interval..."), INTERVAL ); } |