Bug 146504 - "configure podcasts" menu entry has no effect if no podcasts defined
Summary: "configure podcasts" menu entry has no effect if no podcasts defined
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Podcast (show other bugs)
Version: 1.4.7
Platform: Slackware Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-07 18:16 UTC by richlv
Modified: 2007-09-01 20:20 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description richlv 2007-06-07 18:16:17 UTC
Version:           svn 668208 (using KDE KDE 3.5.4)
Installed from:    Slackware Packages
OS:                Linux

i don't have any podcasts defined.
right clicking on "podcasts" entry in the playlist browser brings up context meny that has an entry named "configure podcasts".

unfortunately, this entry does nothing.
it's the same for empty folders that i create under this category.
Comment 1 Christophe 2007-08-31 15:08:10 UTC
Same here with me!
Comment 2 Jeff Mitchell 2007-08-31 21:13:06 UTC
I don't understand the issue.  If you have no podcasts, why are you complaining if  you can't configure them?
Comment 3 Kevin Funk 2007-08-31 23:39:09 UTC
Maybe the configure option should disappear then (gray out)?
Comment 4 Jeff Mitchell 2007-09-01 20:20:08 UTC
SVN commit 707393 by mitchell:

Don't enable "Configure Podcasts" at the top level Podcasts folder if there's nothing underneath.  It'll still be a do-nothing op if only subfolders are 
underneath, but fixing it further is too much needless hacking on stable branch.

BUG: 146504


 M  +2 -0      ChangeLog  
 M  +2 -0      src/playlistbrowseritem.cpp  


--- branches/stable/extragear/multimedia/amarok/ChangeLog #707392:707393
@@ -5,6 +5,8 @@
 
 VERSION 1.4.8
   BUGFIXES:
+    * Don't enable "Configure Podcasts" at the top-level Podcasts folder if
+      there is nothing beneath it. (BR 146504)
     * Generic Media Device could copy some non-ASCII filenames to turn to
       gibberish.  Thanks to David Smith <davidsmith@acm.org> for the fix.
     * Fixed possible GUI freeze when Amarok was showing the dialog for
--- branches/stable/extragear/multimedia/amarok/src/playlistbrowseritem.cpp #707392:707393
@@ -438,6 +438,8 @@
         menu.insertItem( SmallIconSet( Amarok::icon( "refresh" ) ), i18n("Refresh All Podcasts"), REFRESH );
         menu.insertSeparator();
         menu.insertItem( SmallIconSet( Amarok::icon( "configure" ) ), i18n( "&Configure Podcasts..." ), CONFIG );
+        if( parentCat->childCount() == 0 )
+            menu.setItemEnabled( CONFIG, false );
         if( parentCat == this )
             menu.insertItem( SmallIconSet( Amarok::icon( "configure" ) ), i18n("Scan Interval..."), INTERVAL );
     }