| Summary: | pascha (orthodox easter) is not supported in holiday files | ||
|---|---|---|---|
| Product: | [Applications] korganizer | Reporter: | Andriy Gapon <avg> |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | FreeBSD Ports | ||
| OS: | FreeBSD | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | Change easter to pascha | ||
|
Description
Andriy Gapon
2007-04-17 17:00:58 UTC
Yes, it looks like the documentation doesn't match our code. I don't see that libkholidays supports pascha. This bug is confirmed. SVN commit 655833 by winterz: Support Pascha (Orthodox Easter) in holidays files. BUGS: 144347 Andriy: it would be very nice if you could add the necessary pascha entries to all the holidays files that you think should have it. Certainly, Ukraine, Greece, and Russia. Not sure what other countries. M +333 -294 parseholiday.c M +10 -8 parseholiday.h M +28 -5 parseholiday.y M +184 -177 scanholiday.c M +2 -1 scanholiday.lex Although this bug is marked as "resolved" I'd like to continue here. "pascha" now works perfectly with korganizer/libkholidays! I am pasting a patch for the Ukrainian holidays file. I don't see any mention of "easter" or "pascha" in the Russian file, so it probably doesn't need any updates. I'd let people from other countries to take a look at their files (maybe they need some announcement to be alerted). I see a lot of reference to "easter" in a file for Greece. --- holiday_ua Fri Jul 13 18:20:23 2007 +++ holiday_ua Fri Jul 13 18:20:23 2007 @@ -9,9 +9,9 @@ small "Новий Рік" weekend on 1.1 small "Різдво Христове" weekend on 7.1 small "8 Березня - Міжнародний Жіночий День" weekend on 8.3 -small "Великдень" weekend on easter +small "Великдень" weekend on pascha small "1 Травня - День Праці" weekend on 1.5 length 2 days small "День Перемоги" weekend on 9.5 -small "Трійця" weekend on easter plus 46 days +small "Трійця" weekend on pascha plus 46 days small "День Конституції України" weekend on 28.6 small "День Незалежності України" weekend on 24.8 Two URLs to check for Easter and Pascha dates: http://aa.usno.navy.mil/faq/docs/easter.html http://cgi.duke.edu/~aa63/menologion/paschalion.cgi BTW, should I reopen this bug to get the changes committed ? SVN commit 689004 by winterz: easter -> pascha CCBUGS: 144347 M +2 -2 holiday_ua --- branches/KDE/3.5/kdepim/libkholidays/holidays/holiday_ua #689003:689004 @@ -9,9 +9,9 @@ small "Новий Рік" weekend on 1.1 small "Різдво Христове" weekend on 7.1 small "8 Березня - Міжнародний Жіночий День" weekend on 8.3 -small "Великдень" weekend on easter +small "Великдень" weekend on pascha small "1 Травня - День Праці" weekend on 1.5 length 2 days small "День Перемоги" weekend on 9.5 -small "Трійця" weekend on easter plus 46 days +small "Трійця" weekend on pascha plus 46 days small "День Конституції України" weekend on 28.6 small "День Незалежності України" weekend on 24.8 SVN commit 696902 by pradeepto: Merge ... SVN commit 689004 by winterz: easter -> pascha CCBUGS: 144347 M +2 -2 holiday_ua --- branches/kdepim/enterprise/kdepim/libkholidays/holidays/holiday_ua #696901:696902 @@ -9,9 +9,9 @@ small "Новий Рік" weekend on 1.1 small "Різдво Христове" weekend on 7.1 small "8 Березня - Міжнародний Жіночий День" weekend on 8.3 -small "Великдень" weekend on easter +small "Великдень" weekend on pascha small "1 Травня - День Праці" weekend on 1.5 length 2 days small "День Перемоги" weekend on 9.5 -small "Трійця" weekend on easter plus 46 days +small "Трійця" weekend on pascha plus 46 days small "День Конституції України" weekend on 28.6 small "День Незалежності України" weekend on 24.8 Created attachment 23011 [details]
Change easter to pascha
|