Summary: | Keyboard usability issues in "Cover Found" menu | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | David Comeau <nobu> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 1.4-beta3 | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Patch to fix the keyboard shortcuts for the New Search and Next Cover buttons |
Description
David Comeau
2006-04-16 20:37:42 UTC
*coughs* Got a bit overzealous. Keyboard shortcuts work correctly in 1.4-beta3, but modal focus is still wrong. *** Bug 125684 has been marked as a duplicate of this bug. *** Created attachment 15925 [details]
Patch to fix the keyboard shortcuts for the New Search and Next Cover buttons
This patch fixes the keyboard nav shortcuts on the Fetch Cover dialog. Please
note that this should not be subject to the string freeze because the only
change to the string is which letter is the hotkey. This along with the fact
that each language picks its own shortcut key, no retranslation should be
necessary. If that is not possible, perhaps we could create a en_US po file to
translate "Next &Cover" to "&Next Cover" and "New &Search" to "Ne&w Search".
Some additional description: When the "Cover Found" dialog pops up, it does not have focus, but in my version (compiled from source) it is application modal. Before focus is granted, the buttons are as follows, "&Save", "New &Search..", "Next &Cover" and "&Cancel", after clicking, it becomes "&Save", "&New Search..", "N&ext Cover" and "&Cancel". Searching through the code didn't show those strings anywhere. Also, upon clicking "Next Cover" in whichever format, the modal dialog loses focus, probably because it's destroyed and then recreated. Exists in yesterday's SVN also.. We don't normally accept patches which haven't been created properly. It's customary (sorry, mandatory) to not patch the translated files. (*.po) SVN commit 553257 by seb: Don't set keyboard shortcuts for coverfetcher dialog to be conflicting. BUG: 125687 M +2 -2 coverfetcher.cpp M +4 -2 covermanager.cpp --- trunk/extragear/multimedia/amarok/src/coverfetcher.cpp #553256:553257 @@ -553,8 +553,8 @@ QLabel *labelName = new QLabel( this ); QHBox *buttons = new QHBox( this ); KPushButton *save = new KPushButton( KStdGuiItem::save(), buttons ); - KPushButton *newsearch = new KPushButton( i18n( "New &Search..." ), buttons, "NewSearch" ); - KPushButton *nextcover = new KPushButton( i18n( "Next &Cover" ), buttons, "NextCover" ); + KPushButton *newsearch = new KPushButton( i18n( "Ne&w Search..." ), buttons, "NewSearch" ); + KPushButton *nextcover = new KPushButton( i18n( "&Next Cover" ), buttons, "NextCover" ); KPushButton *cancel = new KPushButton( KStdGuiItem::cancel(), buttons ); labelPix ->setAlignment( Qt::AlignHCenter ); --- trunk/extragear/multimedia/amarok/src/covermanager.cpp #553256:553257 @@ -543,14 +543,16 @@ m_coverView->selectAll( false); QIconViewItem *item = m_coverView->firstItem(); - while ( item ) { + while ( item ) + { QIconViewItem *tmp = item->nextItem(); m_coverView->takeItem( item ); item = tmp; } m_coverView->setAutoArrange( false ); - for( QIconViewItem *item = m_coverItems.first(); item; item = m_coverItems.next() ) { + for( QIconViewItem *item = m_coverItems.first(); item; item = m_coverItems.next() ) + { CoverViewItem *coverItem = static_cast<CoverViewItem*>(item); if( coverItem->album().contains( m_filter, false ) || coverItem->artist().contains( m_filter, false ) ) m_coverView->insertItem( item, m_coverView->lastItem() ); |