| Summary: | Solaris keytab name has trailing quote character | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Jonathan Wakely <zilla> |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 1.5 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
Screenshot showing bug
Patch for solaris.keytab Fix spelling mistake in error message |
||
Created attachment 12887 [details]
Screenshot showing bug
Created attachment 12888 [details]
Patch for solaris.keytab
This patch removes the trailing space from the keytab file.
Created attachment 12892 [details]
Fix spelling mistake in error message
This patch is unrelated to this bug, it just fixes a typo (multible) in an
error message in konsole's keytrans.cpp. Not worth filing a new bug though, so
I've attached it here.
SVN commit 467880 by hindenburg:
Fix solaris.keytab space/quote; spelling error.
I don't see the extra " as the screenshot displays.
BUG: 113953
M +1 -1 konsole/keytrans.cpp
M +1 -1 other/solaris.keytab
--- branches/KDE/3.5/kdebase/konsole/konsole/keytrans.cpp #467879:467880
@@ -405,7 +405,7 @@
ptrdiff_t bits = (ptrdiff_t)(syms->modsyms[res]) - 1;
if (mask & (1 << bits))
{
- fprintf(stderr,"%s(%d,%d): mode name used multible times.\n",path.ascii(),slinno,scolno);
+ fprintf(stderr,"%s(%d,%d): mode name used multiple times.\n",path.ascii(),slinno,scolno);
}
else
{
--- branches/KDE/3.5/kdebase/konsole/other/solaris.keytab #467879:467880
@@ -1,7 +1,7 @@
# [solaris.keytab] Konsole Keyboard Table
#
-keyboard "Solaris"
+keyboard "Solaris"
# --------------------------------------------------------------
#
|
Version: 1.5 (using KDE KDE 3.4.0) Installed from: SuSE RPMs Compiler: N/A N/A OS: Linux Settings->Configure Konsole->Session In the Keytab dropdown, Solaris is shown with a trailing quote character (see attached image). This appears to be because solaris.keytab has a trailing space character on this line: keyboard "Solaris" ^ trailing space character I haven't checked the code but it seems that the code to parse the keytab file just assumes that the last character on the line is the closing quote, and just removes the last character. That is a bit poor, but the problem can be avoided by removing the trailing space.