Bug 106345

Summary:	feed always shows some unread articles that have been read
Product:	[Applications] akregator	Reporter:	Helge Hielscher <hhielscher>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gj, zeker
Priority:	NOR
Version:	1.1
Target Milestone:	---
Platform:	Mandrake RPMs
OS:	Linux
Latest Commit:		Version Fixed In:

Description Helge Hielscher 2005-05-26 21:23:26 UTC

Version:           1.1 (using KDE KDE 3.4.0)
Installed from:    Mandrake RPMs

Every time the feed https://blogs.msdn.com:443/ie/atom.aspx gets polled, about 15 articles are displayed as new, no matter if they have previously been marked as read.

Comment 1 Bart Cerneels 2005-06-04 22:47:40 UTC

I'm using KDE3.4.1 and have the same problem. I don't think it was there in 3.4.0.

Comment 2 Bart Cerneels 2005-06-06 10:37:52 UTC

To clarify: this happens to the slashdot feed with me. When fetched the 10 latest articles are marked as unread (and new).
So I confirm this bug.

Comment 3 Heinrich Wendel 2005-06-06 23:20:25 UTC

yes, here to, especially on slashdot, regression from 3.4.0 to 3.4.1

Comment 4 Frank Osterfeld 2005-06-08 10:12:01 UTC

SVN commit 423375 by osterfeld:

Don't use comments count for hash calculation.
So articles with comments count aren't updated anymore when the comments count changed (especially Slashdot).
BUG: 106345


 M  +1 -2      myarticle.cpp  


--- branches/KDE/3.4/kdepim/akregator/src/myarticle.cpp #423374:423375
@@ -100,8 +100,7 @@
         uint parsed = hashStr.toUInt(&parsedOk, 16);
         if (!parsedOk)
         {
-            d->hash = calcHash(title() + description() + link().url() + commentsLink().url()
-                    + QString::number(comments()) );
+            d->hash = calcHash(title() + description() + link().url() + commentsLink().url());
         }
         else
             d->hash = parsed;

Comment 5 Frank Osterfeld 2005-07-31 17:23:20 UTC

*** Bug 109944 has been marked as a duplicate of this bug. ***

Comment 6 Eckhart Wörner 2005-08-10 12:57:32 UTC

*** Bug 110443 has been marked as a duplicate of this bug. ***

Comment 7 Grzegorz Jaskiewicz 2005-08-10 13:08:21 UTC

I'm sorry my friends, but with current svn 3.5 it's NOT fixed, please change resolved to unresolved. Thanks.

Comment 8 Frank Osterfeld 2005-08-10 14:50:26 UTC

Grzegorz: Does it happen all the time or only rarely? If it happens all the time, with which feeds (URLs please)? It would be good if someone having this problem with SVN could apply the patch below.
The first time lots of stuff will be marked as unread, as the hash function is changed. So you need to mark the feed as read and fetch again to test.

--- article.cpp (revision 444115)
+++ article.cpp (working copy)
@@ -344,7 +344,7 @@
 {
     if (str.isNull()) // handle null string as "", prevents crash
         return calcHash("");
-    const char* s = str.ascii();
+    const unsigned short* s = str.ucs2();
     uint hash = 5381;
     int c;
     while ( ( c = *s++ ) ) hash = ((hash << 5) + hash) + c; // hash*33 + c

Comment 9 Grzegorz Jaskiewicz 2005-08-10 16:59:58 UTC

it happends rarely, every few hours. I'll try attached patch on next kde 3.5 
update here (which is today-tomorrow).
Where is about url, try bug I filled out that is DUP to this one ;)
http://blogs.msdn.com/ie/rss.aspx

Comment 10 Grzegorz Jaskiewicz 2005-08-12 23:54:48 UTC

this patch doesn't do any good.
I think problem is somewhere else.